[Bf-blender-cvs] [744a58918a0] master: Fix T72375: Crash when using spin tool

mano-wii noreply at git.blender.org
Thu Jan 9 15:16:05 CET 2020


Commit: 744a58918a0859a782d47ca33c11f6e9f233c044
Author: mano-wii
Date:   Thu Jan 9 11:15:47 2020 -0300
Branches: master
https://developer.blender.org/rB744a58918a0859a782d47ca33c11f6e9f233c044

Fix T72375: Crash when using spin tool

The original geometry referenced in `vtable` was deleted by the
`extrude_face_region` operator.
It is read soon after, so don't delete the original geometry
(param `use_keep_orig`).

This may have a small impact on performance.

===================================================================

M	source/blender/bmesh/operators/bmo_dupe.c

===================================================================

diff --git a/source/blender/bmesh/operators/bmo_dupe.c b/source/blender/bmesh/operators/bmo_dupe.c
index d9a7aa626e4..65b70f62b58 100644
--- a/source/blender/bmesh/operators/bmo_dupe.c
+++ b/source/blender/bmesh/operators/bmo_dupe.c
@@ -543,9 +543,14 @@ void bmo_spin_exec(BMesh *bm, BMOperator *op)
       BMO_op_initf(bm,
                    &extop,
                    op->flag,
-                   "extrude_face_region geom=%S use_normal_flip=%b use_normal_from_adjacent=%b",
+                   "extrude_face_region "
+                   "geom=%S "
+                   "use_keep_orig=%b "
+                   "use_normal_flip=%b "
+                   "use_normal_from_adjacent=%b",
                    op,
                    "geom_last.out",
+                   use_merge,
                    use_normal_flip && (a == 0),
                    (a != 0));
       BMO_op_exec(bm, &extop);



More information about the Bf-blender-cvs mailing list