[Bf-blender-cvs] [5943e7d02e6] master: EEVEE: First Buffer Drawn Incorrectly

Jeroen Bakker noreply at git.blender.org
Tue Feb 25 15:41:21 CET 2020


Commit: 5943e7d02e65b9cdd3f569a6c7fe7ff73f7a28d8
Author: Jeroen Bakker
Date:   Tue Feb 25 15:35:42 2020 +0100
Branches: master
https://developer.blender.org/rB5943e7d02e65b9cdd3f569a6c7fe7ff73f7a28d8

EEVEE: First Buffer Drawn Incorrectly

SSS buffers are lazy initialized when needed. When shaders recompile the
SSS buffers could be incorrectly drawn. During the render passes project
we tried to fix this, but that resulted in incorrect result of the first
sample after a shader was compiled.

We revert this change knowing that we know the issue, but haven't found
a proper solution for it.

===================================================================

M	source/blender/draw/engines/eevee/eevee_engine.c

===================================================================

diff --git a/source/blender/draw/engines/eevee/eevee_engine.c b/source/blender/draw/engines/eevee/eevee_engine.c
index f8e68156aa8..6480847092b 100644
--- a/source/blender/draw/engines/eevee/eevee_engine.c
+++ b/source/blender/draw/engines/eevee/eevee_engine.c
@@ -177,9 +177,6 @@ static void eevee_cache_finish(void *vedata)
   if (g_data->queued_shaders_count != g_data->queued_shaders_count_prev) {
     g_data->queued_shaders_count_prev = g_data->queued_shaders_count;
     EEVEE_temporal_sampling_reset(vedata);
-    /* At this moment the TAA sampling will be redrawn in the next iteration.
-     * we set the taa_current_sample to 0 so the next iteration will use sample 1 */
-    stl->effects->taa_current_sample = 0;
   }
 }



More information about the Bf-blender-cvs mailing list