[Bf-blender-cvs] [dd6012766a6] simulation-tree: remove memory leak

Jacques Lucke noreply at git.blender.org
Wed Feb 19 16:12:20 CET 2020


Commit: dd6012766a63a492da9c121278fe6dca941848d6
Author: Jacques Lucke
Date:   Wed Feb 19 13:22:45 2020 +0100
Branches: simulation-tree
https://developer.blender.org/rBdd6012766a63a492da9c121278fe6dca941848d6

remove memory leak

===================================================================

M	source/blender/simulations/nodes/my_test_node.cc
M	source/blender/windowmanager/intern/wm_init_exit.c

===================================================================

diff --git a/source/blender/simulations/nodes/my_test_node.cc b/source/blender/simulations/nodes/my_test_node.cc
index 86c8550868a..5b6734585e3 100644
--- a/source/blender/simulations/nodes/my_test_node.cc
+++ b/source/blender/simulations/nodes/my_test_node.cc
@@ -315,7 +315,6 @@ static void init_node(bNodeTree *ntree, bNode *node)
   LinearAllocator<> allocator;
   NodeDecl node_decl{*ntree, *node};
   NodeBuilder node_builder{allocator, node_decl};
-  /* TODO: free storage */
   node->storage = callbacks.m_init_storage();
   callbacks.m_declare_node(node_builder);
   node_decl.build();
@@ -496,7 +495,6 @@ void init_socket_data_types()
   socket_data_types->add_data_type(data_socket_int_list);
 }
 
-/* TODO: actually call this function */
 void free_socket_data_types()
 {
   delete socket_data_types;
diff --git a/source/blender/windowmanager/intern/wm_init_exit.c b/source/blender/windowmanager/intern/wm_init_exit.c
index 997b865b8e3..0dc2878571a 100644
--- a/source/blender/windowmanager/intern/wm_init_exit.c
+++ b/source/blender/windowmanager/intern/wm_init_exit.c
@@ -594,6 +594,7 @@ void WM_exit_ex(bContext *C, const bool do_python)
   ANIM_fmodifiers_copybuf_free();
   ED_gpencil_anim_copybuf_free();
   ED_gpencil_strokes_copybuf_free();
+  free_socket_data_types();
 
   /* free gizmo-maps after freeing blender,
    * so no deleted data get accessed during cleaning up of areas. */



More information about the Bf-blender-cvs mailing list