[Bf-blender-cvs] [fd130a711e9] master: GPU: Remove disabling of indirect drawcall batching on NVIDIA hardware

Clément Foucault noreply at git.blender.org
Tue Feb 4 19:13:45 CET 2020


Commit: fd130a711e99723924e99a60a9e11162ca278fd8
Author: Clément Foucault
Date:   Tue Feb 4 19:12:43 2020 +0100
Branches: master
https://developer.blender.org/rBfd130a711e99723924e99a60a9e11162ca278fd8

GPU: Remove disabling of indirect drawcall batching on NVIDIA hardware

Nvidia has fixed their drivers so there is no reasons to keep this.

This fix T70011 NVIDIA issue prevents full indirect draw call batching performance

===================================================================

M	source/blender/gpu/intern/gpu_batch.c

===================================================================

diff --git a/source/blender/gpu/intern/gpu_batch.c b/source/blender/gpu/intern/gpu_batch.c
index 717983f94d8..6b5d3053594 100644
--- a/source/blender/gpu/intern/gpu_batch.c
+++ b/source/blender/gpu/intern/gpu_batch.c
@@ -781,11 +781,8 @@ void GPU_draw_primitive(GPUPrimType prim_type, int v_count)
 #if 0
 #  define USE_MULTI_DRAW_INDIRECT 0
 #else
-/* TODO: partial workaround for NVIDIA driver bug on recent GTX/RTX cards,
- * that breaks instancing when using indirect draw-call (see T70011). */
 #  define USE_MULTI_DRAW_INDIRECT \
-    (GL_ARB_multi_draw_indirect && GPU_arb_base_instance_is_supported() && \
-     !GPU_type_matches(GPU_DEVICE_NVIDIA, GPU_OS_ANY, GPU_DRIVER_OFFICIAL))
+    (GL_ARB_multi_draw_indirect && GPU_arb_base_instance_is_supported())
 #endif
 
 typedef struct GPUDrawCommand {



More information about the Bf-blender-cvs mailing list