[Bf-blender-cvs] [2d6e6d035b6] master: Nla Refactor: Better blend function parm naming
Wayde Moss
noreply at git.blender.org
Mon Dec 21 20:13:04 CET 2020
Commit: 2d6e6d035b664d6244fd48090cb8545145032f9f
Author: Wayde Moss
Date: Mon Dec 21 13:58:36 2020 -0500
Branches: master
https://developer.blender.org/rB2d6e6d035b664d6244fd48090cb8545145032f9f
Nla Refactor: Better blend function parm naming
**Renames parms**:
| **old name** | **new name**
| old_value | lower_value
| target_value | blended_value
| value | strip_value
| inf | influence
**Reason**: {D8296} allows full nla stack evaluation with proper
keyframing support. These names should make it more intuitive how all
the data gets processed and inverted. Note, that I do use the term
"strip_value" instead of something like "fcurve_value" of the tweak
strip. Technically, "strip_value" is closer to what is solved for.
For example, if a noise fmodifier was active for the fcurve, then the
remapping would appear to be wrong. In the future, further solving can
be done afterward, outside of the nla system, to remove the effects of
fmodifiers.
**Renames functions**:
| nla_invert_blend_value | nla_blend_get_inverted_strip_value
| nla_invert_combine_value | nla_combine_get_inverted_strip_value
**Reason**: D8296 adds get_inverted_lower_value() variants,
so "invert" alone is too vague.
**Renames NlaKeyframingContext member**:
| nla_channels | lower_eval_data
**Reason**: D8296 evaluates the upper stack. This name makes it more
obvious what data is stored there.
No functional changes (relative to the dependency below)
Split from {D9247}
Depends on {D9694} since the code was so close to eachother.
Reviewed By: sybren
Differential Revision: https://developer.blender.org/D9695
===================================================================
M source/blender/blenkernel/intern/anim_sys.c
M source/blender/blenkernel/nla_private.h
===================================================================
diff --git a/source/blender/blenkernel/intern/anim_sys.c b/source/blender/blenkernel/intern/anim_sys.c
index ea41495d097..20956d6eb18 100644
--- a/source/blender/blenkernel/intern/anim_sys.c
+++ b/source/blender/blenkernel/intern/anim_sys.c
@@ -1421,125 +1421,147 @@ static NlaEvalChannel *nlaevalchan_verify(PointerRNA *ptr, NlaEvalData *nlaeval,
/* ---------------------- */
-/* accumulate the old and new values of a channel according to mode and influence */
-static float nla_blend_value(int blendmode, float old_value, float value, float inf)
+/* Blend the lower nla stack value and upper strip value of a channel according to mode and
+ * influence. */
+static float nla_blend_value(const int blendmode,
+ const float lower_value,
+ const float strip_value,
+ const float influence)
{
/* Optimization: no need to try applying if there is no influence. */
- if (IS_EQF(inf, 0.0f)) {
- return old_value;
+ if (IS_EQF(influence, 0.0f)) {
+ return lower_value;
}
- /* perform blending */
+ /* Perform blending. */
switch (blendmode) {
case NLASTRIP_MODE_ADD:
- /* simply add the scaled value on to the stack */
- return old_value + (value * inf);
+ /* Simply add the scaled value on to the stack. */
+ return lower_value + (strip_value * influence);
case NLASTRIP_MODE_SUBTRACT:
- /* simply subtract the scaled value from the stack */
- return old_value - (value * inf);
+ /* Simply subtract the scaled value from the stack. */
+ return lower_value - (strip_value * influence);
case NLASTRIP_MODE_MULTIPLY:
- /* multiply the scaled value with the stack */
- /* Formula Used:
- * result = fac * (a * b) + (1 - fac) * a
- */
- return inf * (old_value * value) + (1 - inf) * old_value;
+ /* Multiply the scaled value with the stack. */
+ return influence * (lower_value * strip_value) + (1 - influence) * lower_value;
case NLASTRIP_MODE_COMBINE:
BLI_assert(!"combine mode");
ATTR_FALLTHROUGH;
- case NLASTRIP_MODE_REPLACE:
- default
- : /* TODO: do we really want to blend by default? it seems more uses might prefer add... */
- /* do linear interpolation
- * - the influence of the accumulated data (elsewhere, that is called dstweight)
- * is 1 - influence, since the strip's influence is srcweight
+ default:
+ /* TODO: Do we really want to blend by default? it seems more uses might prefer add... */
+ /* Do linear interpolation. The influence of the accumulated data (elsewhere, that is called
+ * dstweight) is 1 - influence, since the strip's influence is srcweight.
*/
- return old_value * (1.0f - inf) + (value * inf);
+ return lower_value * (1.0f - influence) + (strip_value * influence);
}
}
-/* accumulate the old and new values of a channel according to mode and influence */
-static float nla_combine_value(
- int mix_mode, float base_value, float old_value, float value, float inf)
+/* Blend the lower nla stack value and upper strip value of a channel according to mode and
+ * influence. */
+static float nla_combine_value(const int mix_mode,
+ float base_value,
+ const float lower_value,
+ const float strip_value,
+ const float influence)
{
- /* Optimization: no need to try applying if there is no influence. */
- if (IS_EQF(inf, 0.0f)) {
- return old_value;
+ /* Optimization: No need to try applying if there is no influence. */
+ if (IS_EQF(influence, 0.0f)) {
+ return lower_value;
}
- /* perform blending */
+ /* Perform blending */
switch (mix_mode) {
case NEC_MIX_ADD:
case NEC_MIX_AXIS_ANGLE:
- return old_value + (value - base_value) * inf;
+ return lower_value + (strip_value - base_value) * influence;
case NEC_MIX_MULTIPLY:
if (IS_EQF(base_value, 0.0f)) {
base_value = 1.0f;
}
- return old_value * powf(value / base_value, inf);
+ return lower_value * powf(strip_value / base_value, influence);
- case NEC_MIX_QUATERNION:
default:
BLI_assert(!"invalid mix mode");
- return old_value;
+ return lower_value;
}
}
-/* compute the value that would blend to the desired target value using nla_blend_value */
-static bool nla_invert_blend_value(
- int blend_mode, float old_value, float target_value, float influence, float *r_value)
+/** \returns true if solution exists and output is written to. */
+static bool nla_blend_get_inverted_strip_value(const int blendmode,
+ const float lower_value,
+ const float blended_value,
+ const float influence,
+ float *r_strip_value)
{
/** No solution if strip had 0 influence. */
if (IS_EQF(influence, 0.0f)) {
return false;
}
- switch (blend_mode) {
+ switch (blendmode) {
case NLASTRIP_MODE_ADD:
- *r_value = (target_value - old_value) / influence;
+ *r_strip_value = (blended_value - lower_value) / influence;
return true;
case NLASTRIP_MODE_SUBTRACT:
- *r_value = (old_value - target_value) / influence;
+ *r_strip_value = (lower_value - blended_value) / influence;
return true;
case NLASTRIP_MODE_MULTIPLY:
- if (IS_EQF(old_value, 0.0f)) {
+ if (IS_EQF(lower_value, 0.0f)) {
/* Resolve 0/0 to 1. */
- if (IS_EQF(target_value, 0.0f)) {
- *r_value = 1.0f;
+ if (IS_EQF(blended_value, 0.0f)) {
+ *r_strip_value = 1.0f;
return true;
}
/* Division by zero. */
return false;
}
- else {
- *r_value = (target_value - old_value) / influence / old_value + 1.0f;
- return true;
- }
+
+ /** Math:
+ *
+ * blended_value = inf * (lower_value * strip_value) + (1 - inf) * lower_value
+ * blended_value - (1 - inf) * lower_value = inf * (lower_value * strip_value)
+ * (blended_value - (1 - inf) * lower_value) / (inf * lower_value) = strip_value
+ * (blended_value - lower_value + inf * lower_value) / (inf * lower_value) = strip_value
+ * ((blended_value - lower_value) / (inf * lower_value)) + 1 = strip_value
+ *
+ * strip_value = ((blended_value - lower_value) / (inf * lower_value)) + 1
+ */
+ *r_strip_value = ((blended_value - lower_value) / (influence * lower_value)) + 1.0f;
+ return true;
case NLASTRIP_MODE_COMBINE:
BLI_assert(!"combine mode");
ATTR_FALLTHROUGH;
- case NLASTRIP_MODE_REPLACE:
default:
- *r_value = (target_value - old_value) / influence + old_value;
+
+ /** Math:
+ *
+ * blended_value = lower_value * (1.0f - inf) + (strip_value * inf)
+ * blended_value - lower_value * (1.0f - inf) = (strip_value * inf)
+ * (blended_value - lower_value * (1.0f - inf)) / inf = strip_value
+ *
+ * strip_value = (blended_value - lower_value * (1.0f - inf)) / inf
+ */
+ *r_strip_value = (blended_value - lower_value * (1.0f - influence)) / influence;
return true;
}
}
-/* compute the value that would blend to the desired target value using nla_combine_value */
-static bool nla_invert_combine_value(int mix_mode,
- float base_value,
- float old_value,
- float target_value,
- float influence,
- float *r_value)
+/** \returns true if solution exists and output is written to. */
+static bool nla_combine_get_inverted_strip_value(const int mix_mode,
+ float base_value,
+ const float lower_value,
+ const float blended_value,
+ const float influence,
+ float *r_strip_value)
{
/* No solution if strip had no influence. */
if (IS_EQF(influence, 0.0f)) {
@@ -1549,65 +1571,72 @@ static bool nla_invert_combine_value(int mix_mode,
switch (mix_mode) {
case NEC_MIX_ADD:
case NEC_MIX_AXIS_ANGLE:
- *r_value = base_value + (target_value - old_value) / influence;
+ *r_strip_value = base_value + (blended_value - lower_value) / influence;
return true;
case NEC_MIX_MULTIPLY:
if (IS_EQF(base_value, 0.0f)) {
base_value = 1.0f;
}
- if (IS_EQF(old_value, 0.0f)) {
+ /* Divison by zero. */
+ if (IS_EQF(lower_value, 0.0f)) {
/* Resolve 0/0 to 1. */
- if (IS_EQF(target_value, 0.0f)) {
- *r_value = base_value;
+ if (IS_EQF(blended_value, 0.0f)) {
+ *r_strip_value = base_value;
return true;
}
/* Division by zero. */
return false;
}
- *r_value = base_value * powf(target_value / old_value, 1.0f / influence);
+ *r_strip_value = base_value * powf(blended_value / lower_value, 1.0f / influence);
return true;
- case NEC_MIX_QUATERNION:
default:
BLI_assert(!"invalid mix mode");
return false;
}
}
-/* accumulate quaternion channels for Combine mode according to influence */
-static void nla_combine_quaternion(const float old_values[4],
- const float values[4],
- float influence,
- float result[4])
+/** Accumulate quaternion channels for Combine mode according to influence.
+ * \returns blended_value = lower_values @ strip_values^infl
+ */
+static void nla_combine_quaternion(const float lower_values[4],
+ const float strip_values[4],
+ const float influence,
+
@@ Diff output truncated at 10240 characters. @@
More information about the Bf-blender-cvs
mailing list