[Bf-blender-cvs] [adda1d2b23d] temp-lineart-contained: Revert "Codesign: Versioning code to support older branches"

Sergey Sharybin noreply at git.blender.org
Sat Dec 19 06:18:52 CET 2020


Commit: adda1d2b23d26c277cfa8a459092506ba2a08c14
Author: Sergey Sharybin
Date:   Fri Nov 13 11:35:04 2020 +0100
Branches: temp-lineart-contained
https://developer.blender.org/rBadda1d2b23d26c277cfa8a459092506ba2a08c14

Revert "Codesign: Versioning code to support older branches"

This reverts commit 9d172f007eeb5ade5ddad03e1f71fa4c373855f8.

Got a second thought and remembered why it was not done in the first place.
The issue here is that the server needs to communicate codesign result back
and that must happen within the new protocol. So if the client talks old
protocol it is possible to receieve data from it, but is not possible to
communicate result back to it.

===================================================================

M	build_files/buildbot/codesign/archive_with_indicator.py

===================================================================

diff --git a/build_files/buildbot/codesign/archive_with_indicator.py b/build_files/buildbot/codesign/archive_with_indicator.py
index 9f903ddd9fe..aebf5a15417 100644
--- a/build_files/buildbot/codesign/archive_with_indicator.py
+++ b/build_files/buildbot/codesign/archive_with_indicator.py
@@ -76,15 +76,6 @@ class ArchiveState:
         except json.decoder.JSONDecodeError:
             raise ArchiveStateError('Error parsing JSON')
 
-        # NOTE: Compatibility code with older codesign code from times when client
-        # did not use JSON for the archive indicator. After all branches has codesign
-        # merged this code should be removed.
-        if type(object_as_dict) == int:
-            result = cls()
-            result.file_size = int(object_as_dict)
-            result.error_message = ''
-            return result
-
         return cls(**object_as_dict)
 
     @classmethod



More information about the Bf-blender-cvs mailing list