[Bf-blender-cvs] [ffe63b0440c] master: Fix crash opening maximized File Browser from Asset Browser

Julian Eisel noreply at git.blender.org
Tue Dec 15 18:56:29 CET 2020


Commit: ffe63b0440cb55dee7a0ec3c383cce99167b47a1
Author: Julian Eisel
Date:   Tue Dec 15 18:49:56 2020 +0100
Branches: master
https://developer.blender.org/rBffe63b0440cb55dee7a0ec3c383cce99167b47a1

Fix crash opening maximized File Browser from Asset Browser

If Preferences > Interface > Temporary Editors > File Browser is set to
"Maximized Area", opening a File Browser from an Asset Browser would
cause the new maximized editor to be an Asset Browser. Exiting it again
would crash.

This fixes the wrong behavior and the crash. There's still an issue with
exiting the editor again, it stays a File Browser then and doesn't go
back to being an Asset Browser. That's to be fixed separately.

===================================================================

M	source/blender/editors/screen/screen_edit.c
M	source/blender/editors/space_file/filesel.c

===================================================================

diff --git a/source/blender/editors/screen/screen_edit.c b/source/blender/editors/screen/screen_edit.c
index 6be2fb8004b..c3dcaefab79 100644
--- a/source/blender/editors/screen/screen_edit.c
+++ b/source/blender/editors/screen/screen_edit.c
@@ -1369,6 +1369,7 @@ ScrArea *ED_screen_state_toggle(bContext *C, wmWindow *win, ScrArea *area, const
     newa->full = oldscreen;
 
     ED_screen_change(C, screen);
+    ED_area_tag_refresh(newa);
   }
 
   /* XXX bad code: setscreen() ends with first area active. fullscreen render assumes this too */
diff --git a/source/blender/editors/space_file/filesel.c b/source/blender/editors/space_file/filesel.c
index cd27b7b5773..b919a30e6cd 100644
--- a/source/blender/editors/space_file/filesel.c
+++ b/source/blender/editors/space_file/filesel.c
@@ -490,7 +490,7 @@ void ED_fileselect_set_params_from_userdef(SpaceFile *sfile)
   wmOperator *op = sfile->op;
   UserDef_FileSpaceData *sfile_udata = &U.file_space_data;
 
-  BLI_assert(sfile->browse_mode == FILE_BROWSE_MODE_FILES);
+  sfile->browse_mode = FILE_BROWSE_MODE_FILES;
 
   FileSelectParams *params = fileselect_ensure_updated_file_params(sfile);
   if (!op) {



More information about the Bf-blender-cvs mailing list