[Bf-blender-cvs] [d1cedf53faa] master: Revert "Fix T78823: Slash in custom property name does not work"

Campbell Barton noreply at git.blender.org
Wed Dec 9 05:30:36 CET 2020


Commit: d1cedf53faaf11de74ca7c88da207e16ae01c497
Author: Campbell Barton
Date:   Wed Dec 9 15:25:18 2020 +1100
Branches: master
https://developer.blender.org/rBd1cedf53faaf11de74ca7c88da207e16ae01c497

Revert "Fix T78823: Slash in custom property name does not work"

This reverts commit cbae82ba960a0baaae6437b176a310f078ce07d8.

This change introduced the following problems:

- We could no longer reliably duplicate or use an existing
  custom property names.
- We could no longer assume a bone or ID name
  can be used in a custom-property.
- Importers that support custom properties (such as FBX)
  could fail with an exception creating custom properties.

===================================================================

M	source/blender/python/generic/idprop_py_api.c

===================================================================

diff --git a/source/blender/python/generic/idprop_py_api.c b/source/blender/python/generic/idprop_py_api.c
index a8b66f3f2fe..1a7a0ecc6d7 100644
--- a/source/blender/python/generic/idprop_py_api.c
+++ b/source/blender/python/generic/idprop_py_api.c
@@ -20,8 +20,6 @@
 
 #include <Python.h>
 
-#include <string.h>
-
 #include "MEM_guardedalloc.h"
 
 #include "BLI_utildefines.h"
@@ -372,11 +370,6 @@ static const char *idp_try_read_name(PyObject *name_obj)
                       "the length of IDProperty names is limited to 63 characters");
       return NULL;
     }
-
-    if (strchr(name, '\"') || strchr(name, '\\') || strchr(name, '\'')) {
-      PyErr_SetString(PyExc_KeyError, "IDProperty names cannot include \", \\, or \'");
-      return NULL;
-    }
   }
   else {
     name = "";



More information about the Bf-blender-cvs mailing list