[Bf-blender-cvs] [e0c199a527e] geometry-nodes-point-separate-node: Review feedback: Only move pointcloud, use numbers for naming

Hans Goudey noreply at git.blender.org
Mon Dec 7 19:03:34 CET 2020


Commit: e0c199a527e7052b294f39bbca6d56c27923abbf
Author: Hans Goudey
Date:   Mon Dec 7 11:56:00 2020 -0600
Branches: geometry-nodes-point-separate-node
https://developer.blender.org/rBe0c199a527e7052b294f39bbca6d56c27923abbf

Review feedback: Only move pointcloud, use numbers for naming

===================================================================

M	source/blender/nodes/geometry/nodes/node_geo_point_separate.cc

===================================================================

diff --git a/source/blender/nodes/geometry/nodes/node_geo_point_separate.cc b/source/blender/nodes/geometry/nodes/node_geo_point_separate.cc
index d3cf1fc3a8d..0ec25aae5cd 100644
--- a/source/blender/nodes/geometry/nodes/node_geo_point_separate.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_point_separate.cc
@@ -31,8 +31,8 @@ static bNodeSocketTemplate geo_node_point_instance_in[] = {
 };
 
 static bNodeSocketTemplate geo_node_point_instance_out[] = {
-    {SOCK_GEOMETRY, N_("Geometry A")},
-    {SOCK_GEOMETRY, N_("Geometry B")},
+    {SOCK_GEOMETRY, N_("Geometry 1")},
+    {SOCK_GEOMETRY, N_("Geometry 2")},
     {-1, ""},
 };
 
@@ -158,7 +158,7 @@ static void geo_node_point_separate_exec(GeoNodeExecParams params)
 {
   GeometrySet geometry_set = params.extract_input<GeometrySet>("Geometry");
   GeometrySet out_set_a(geometry_set);
-  GeometrySet out_set_b(geometry_set);
+  GeometrySet out_set_b;
 
   const std::string mask_name = params.extract_input<std::string>("Mask");
 
@@ -169,8 +169,8 @@ static void geo_node_point_separate_exec(GeoNodeExecParams params)
                          out_set_b.get_component_for_write<PointCloudComponent>());
   }
 
-  params.set_output("Geometry A", std::move(out_set_a));
-  params.set_output("Geometry B", std::move(out_set_b));
+  params.set_output("Geometry 1", std::move(out_set_a));
+  params.set_output("Geometry 2", std::move(out_set_b));
 }
 }  // namespace blender::nodes



More information about the Bf-blender-cvs mailing list