[Bf-blender-cvs] [a2ddb36c438] cycles_procedural_api: add comment

Kévin Dietrich noreply at git.blender.org
Sun Dec 6 06:26:29 CET 2020


Commit: a2ddb36c438cef94b2569ce06772f6a7033fe2d5
Author: Kévin Dietrich
Date:   Fri Dec 4 12:46:53 2020 +0100
Branches: cycles_procedural_api
https://developer.blender.org/rBa2ddb36c438cef94b2569ce06772f6a7033fe2d5

add comment

===================================================================

M	intern/cycles/render/alembic.cpp

===================================================================

diff --git a/intern/cycles/render/alembic.cpp b/intern/cycles/render/alembic.cpp
index 33543936b38..b24d132aa28 100644
--- a/intern/cycles/render/alembic.cpp
+++ b/intern/cycles/render/alembic.cpp
@@ -534,6 +534,10 @@ void AlembicObject::load_all_data(IPolyMeshSchema &schema, Progress &progress)
 
     add_positions(sample.getPositions(), time, cached_data);
 
+    /* TODO(@kevindietrich): this is a waste of memory and processing time if only the positions
+     * are changing but we cannot optimize in this current system if the attributes are changing
+     * over time as well, as we need valid data for each time point. This can be solved by using
+     * reference counting on the array and simply share the array across frames. */
     add_triangles(
         sample.getFaceCounts(), sample.getFaceIndices(), time, cached_data, polygon_to_shader);



More information about the Bf-blender-cvs mailing list