[Bf-blender-cvs] [fbcedf96cbf] property-search-ui-v2: Property Search: Add comment explaining menu search limitation

Hans Goudey noreply at git.blender.org
Wed Aug 26 16:24:40 CEST 2020


Commit: fbcedf96cbf88afce797c6207ec67bc0dc3dc14a
Author: Hans Goudey
Date:   Wed Aug 26 09:24:24 2020 -0500
Branches: property-search-ui-v2
https://developer.blender.org/rBfbcedf96cbf88afce797c6207ec67bc0dc3dc14a

Property Search: Add comment explaining menu search limitation

===================================================================

M	source/blender/editors/interface/interface_layout.c

===================================================================

diff --git a/source/blender/editors/interface/interface_layout.c b/source/blender/editors/interface/interface_layout.c
index bb8dec520f6..82d5ab96d3b 100644
--- a/source/blender/editors/interface/interface_layout.c
+++ b/source/blender/editors/interface/interface_layout.c
@@ -5188,7 +5188,9 @@ static bool button_matches_search_filter(uiBut *but, const char *search_filter)
     }
 #endif
 
-    /* Search through labels of enum property items if they are in a dropdown menu. */
+    /* Search through labels of enum property items if they are in a dropdown menu.
+     * Unfortunately we have no context here so we cannot search through RNA enums
+     * with dynamic entries (or "itemf" functions) which require context. */
     if (but->type == UI_BTYPE_MENU) {
       PointerRNA *ptr = &but->rnapoin;
       PropertyRNA *enum_prop = but->rnaprop;



More information about the Bf-blender-cvs mailing list