[Bf-blender-cvs] [cb294c3a01b] master: Fix buffer-overflow when drawing Curve Guide objects

Julian Eisel noreply at git.blender.org
Thu Aug 6 14:14:20 CEST 2020


Commit: cb294c3a01bd82907c87549f7a09184369104925
Author: Julian Eisel
Date:   Thu Aug 6 14:12:23 2020 +0200
Branches: master
https://developer.blender.org/rBcb294c3a01bd82907c87549f7a09184369104925

Fix buffer-overflow when drawing Curve Guide objects

Was passing an array of length 3 to `where_on_path()` that expected
length 4.

===================================================================

M	source/blender/draw/engines/overlay/overlay_extra.c

===================================================================

diff --git a/source/blender/draw/engines/overlay/overlay_extra.c b/source/blender/draw/engines/overlay/overlay_extra.c
index 1e766b3cc39..60e622ca706 100644
--- a/source/blender/draw/engines/overlay/overlay_extra.c
+++ b/source/blender/draw/engines/overlay/overlay_extra.c
@@ -545,7 +545,7 @@ static void OVERLAY_forcefield(OVERLAY_ExtraCallBuffers *cb, Object *ob, ViewLay
       if (cu && (cu->flag & CU_PATH) && ob->runtime.curve_cache->path &&
           ob->runtime.curve_cache->path->data) {
         instdata.size_x = instdata.size_y = instdata.size_z = pd->f_strength;
-        float pos[3], tmp[3];
+        float pos[4], tmp[3];
         where_on_path(ob, 0.0f, pos, tmp, NULL, NULL, NULL);
         copy_v3_v3(instdata.pos, ob->obmat[3]);
         translate_m4(instdata.mat, pos[0], pos[1], pos[2]);



More information about the Bf-blender-cvs mailing list