[Bf-blender-cvs] [f60d614c5f5] modifier-panels-ui: Fix use-after-free

Julian Eisel noreply at git.blender.org
Sun Apr 5 01:53:43 CEST 2020


Commit: f60d614c5f5d15f1033cd718be4eb6ce0a3d1423
Author: Julian Eisel
Date:   Sun Apr 5 01:44:55 2020 +0200
Branches: modifier-panels-ui
https://developer.blender.org/rBf60d614c5f5d15f1033cd718be4eb6ce0a3d1423

Fix use-after-free

===================================================================

M	source/blender/editors/interface/interface_panel.c

===================================================================

diff --git a/source/blender/editors/interface/interface_panel.c b/source/blender/editors/interface/interface_panel.c
index abaac1be1d6..232a5611ebc 100644
--- a/source/blender/editors/interface/interface_panel.c
+++ b/source/blender/editors/interface/interface_panel.c
@@ -2702,13 +2702,13 @@ static void panel_activate_state(const bContext *C, Panel *pa, uiHandlePanelStat
   }
 
   if (state == PANEL_STATE_EXIT) {
-    MEM_freeN(data);
-    pa->activedata = NULL;
-
     if (data->is_drag_drop) {
       reorder_recreate_panel_list(C, region, pa);
     }
 
+    MEM_freeN(data);
+    pa->activedata = NULL;
+
     WM_event_remove_ui_handler(
         &win->modalhandlers, ui_handler_panel, ui_handler_remove_panel, pa, false);
   }



More information about the Bf-blender-cvs mailing list