[Bf-blender-cvs] [95749f5d548] master: Fix T70522: Sidebars in Clip Editor work incorrectly in Dopesheet mode

Julian Eisel noreply at git.blender.org
Tue Oct 8 10:35:36 CEST 2019


Commit: 95749f5d548c9cd304b2f8399c791c98e431a19e
Author: Julian Eisel
Date:   Tue Oct 8 10:29:27 2019 +0200
Branches: master
https://developer.blender.org/rB95749f5d548c9cd304b2f8399c791c98e431a19e

Fix T70522: Sidebars in Clip Editor work incorrectly in Dopesheet mode

Actually, in Dopesheet mode, the regions shouldn't be toggle-able at
all. For the user they should appear to not exist.
Previously the Movie Clip Editor archieved this by setting the region
alignments to NONE, which this restores.

Introduced in 6aef124e7d28.

===================================================================

M	source/blender/makesrna/intern/rna_space.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_space.c b/source/blender/makesrna/intern/rna_space.c
index 52aca9bdea5..01532d8568b 100644
--- a/source/blender/makesrna/intern/rna_space.c
+++ b/source/blender/makesrna/intern/rna_space.c
@@ -589,7 +589,7 @@ static void rna_Space_bool_from_region_flag_set_by_type(PointerRNA *ptr,
 {
   ScrArea *sa = rna_area_from_space(ptr);
   ARegion *ar = BKE_area_find_region_type(sa, region_type);
-  if (ar) {
+  if (ar && (ar->alignment != RGN_ALIGN_NONE)) {
     SET_FLAG_FROM_TEST(ar->flag, value, region_flag);
   }
   ED_region_tag_redraw(ar);



More information about the Bf-blender-cvs mailing list