[Bf-blender-cvs] [9ecc30250aa] master: Fix T71909: Any keyframed GPLayer property is not updated when render animation

[Antonio Vazquez]

Commit: 9ecc30250aaea4e102e869f181e4c896c315e5ef
Author: Antonio Vazquez
Date:   Tue Nov 26 14:05:00 2019 +0100
Branches: master
https://developer.blender.org/rB9ecc30250aaea4e102e869f181e4c896c315e5ef

Fix T71909: Any keyframed GPLayer property is not updated when render animation

By error, the original datablock was used while rendering. Actually, only while the user is drawing the original data must be used because when we tested, the time the system uses to copy the datablock created a very bad "lag" feeling while drawing. Maybe the lag was half second only, but it ruined the pencil feeling.

I talked some time ago with Sergey about that and we decided use this approach.

Now, only the original datablock is used while the user is "moving" the pen, but not in any other situation.

Thanks @sergey for help me with this bug and sorry for thinking it was a depsgraph issue.

===================================================================

M	source/blender/draw/engines/gpencil/gpencil_draw_utils.c

===================================================================

diff --git a/source/blender/draw/engines/gpencil/gpencil_draw_utils.c b/source/blender/draw/engines/gpencil/gpencil_draw_utils.c
index efc73fd1056..48912a914dc 100644
--- a/source/blender/draw/engines/gpencil/gpencil_draw_utils.c
+++ b/source/blender/draw/engines/gpencil/gpencil_draw_utils.c
@@ -2077,9 +2077,7 @@ void gpencil_populate_datablock(GPENCIL_e_data *e_data,
     BKE_gpencil_modifiers_calc(draw_ctx->depsgraph, draw_ctx->scene, ob);
   }
 
-  /* Use original data to shared in edit/transform operators */
-  bGPdata *gpd_eval = (bGPdata *)ob->data;
-  bGPdata *gpd = (bGPdata *)DEG_get_original_id(&gpd_eval->id);
+  bGPdata *gpd = (bGPdata *)ob->data;
 
   const bool main_onion = stl->storage->is_main_onion;
   const bool playing = stl->storage->is_playing;