[Bf-blender-cvs] [8cfd46a5b00] master: Wireframe: Make wireframe's Xray slider default to 0

[Clément Foucault]

Commit: 8cfd46a5b00bc868c792543cb89a4957aeda634f
Author: Clément Foucault
Date:   Mon May 27 12:54:32 2019 +0200
Branches: master
https://developer.blender.org/rB8cfd46a5b00bc868c792543cb89a4957aeda634f

Wireframe: Make wireframe's Xray slider default to 0

This removes the dither patterns visible in wireframe mode.
This does decrease de depth perception but many users complained
about the visual noise it produces.

===================================================================

M	source/blender/blenkernel/intern/screen.c
M	source/blender/blenloader/intern/versioning_280.c
M	source/blender/blenloader/intern/versioning_defaults.c

===================================================================

diff --git a/source/blender/blenkernel/intern/screen.c b/source/blender/blenkernel/intern/screen.c
index bc9ec6b28e6..3ff8b6ff18c 100644
--- a/source/blender/blenkernel/intern/screen.c
+++ b/source/blender/blenkernel/intern/screen.c
@@ -843,7 +843,7 @@ void BKE_screen_view3d_shading_init(View3DShading *shading)
   shading->light = V3D_LIGHTING_STUDIO;
   shading->shadow_intensity = 0.5f;
   shading->xray_alpha = 0.5f;
-  shading->xray_alpha_wire = 0.5f;
+  shading->xray_alpha_wire = 0.0f;
   shading->cavity_valley_factor = 1.0f;
   shading->cavity_ridge_factor = 1.0f;
   shading->cavity_type = V3D_SHADING_CAVITY_CURVATURE;
diff --git a/source/blender/blenloader/intern/versioning_280.c b/source/blender/blenloader/intern/versioning_280.c
index a783e35f652..70379c41b83 100644
--- a/source/blender/blenloader/intern/versioning_280.c
+++ b/source/blender/blenloader/intern/versioning_280.c
@@ -2352,7 +2352,7 @@ void blo_do_versions_280(FileData *fd, Library *UNUSED(lib), Main *bmain)
           for (SpaceLink *sl = sa->spacedata.first; sl; sl = sl->next) {
             if (sl->spacetype == SPACE_VIEW3D) {
               View3D *v3d = (View3D *)sl;
-              v3d->shading.xray_alpha_wire = 0.5f;
+              v3d->shading.xray_alpha_wire = 0.0f;
             }
           }
         }
diff --git a/source/blender/blenloader/intern/versioning_defaults.c b/source/blender/blenloader/intern/versioning_defaults.c
index dfcde05dedf..65dc38bd4b9 100644
--- a/source/blender/blenloader/intern/versioning_defaults.c
+++ b/source/blender/blenloader/intern/versioning_defaults.c
@@ -196,6 +196,8 @@ void BLO_update_defaults_startup_blend(Main *bmain, const char *app_template)
             /* grease pencil settings */
             v3d->vertex_opacity = 1.0f;
             v3d->gp_flag |= V3D_GP_SHOW_EDIT_LINES;
+            /* Remove dither pattern in wireframe mode. */
+            v3d->shading.xray_alpha_wire = 0.0f;
             /* Skip startups that use the viewport color by default. */
             if (v3d->shading.background_type != V3D_SHADING_BACKGROUND_VIEWPORT) {
               copy_v3_fl(v3d->shading.background_color, 0.05f);