[Bf-blender-cvs] [04ad9eab6ea] master: Fix: Too many checks for the compositor

William Reynish noreply at git.blender.org
Fri May 24 17:11:55 CEST 2019


Commit: 04ad9eab6ea9951ef70b5b60b16fd7868c2fb5dd
Author: William Reynish
Date:   Fri May 24 17:11:53 2019 +0200
Branches: master
https://developer.blender.org/rB04ad9eab6ea9951ef70b5b60b16fd7868c2fb5dd

Fix: Too many checks for the compositor

Check once as and then re-use

===================================================================

M	release/scripts/startup/bl_ui/space_node.py

===================================================================

diff --git a/release/scripts/startup/bl_ui/space_node.py b/release/scripts/startup/bl_ui/space_node.py
index 13d66dc851a..14c3d4925a8 100644
--- a/release/scripts/startup/bl_ui/space_node.py
+++ b/release/scripts/startup/bl_ui/space_node.py
@@ -54,6 +54,7 @@ class NODE_HT_header(Header):
         snode_id = snode.id
         id_from = snode.id_from
         tool_settings = context.tool_settings
+        is_compositor = snode.tree_type == 'CompositorNodeTree'
 
         layout.template_header()
 
@@ -159,19 +160,19 @@ class NODE_HT_header(Header):
             layout.template_ID(snode, "node_tree", new="node.new_node_tree")
 
         # Put pin next to ID block
-        if snode.tree_type != 'CompositorNodeTree':
+        if not is_compositor:
             layout.prop(snode, "pin", text="", emboss=False)
 
         layout.separator_spacer()
 
         # Put pin on the right for Compositing
-        if snode.tree_type == 'CompositorNodeTree':
+        if is_compositor:
             layout.prop(snode, "pin", text="", emboss=False)
 
         layout.operator("node.tree_path_parent", text="", icon='FILE_PARENT')
 
         # Backdrop
-        if snode.tree_type == 'CompositorNodeTree':
+        if is_compositor:
             row=layout.row(align=True)
             row.prop(snode, "show_backdrop", toggle=True)
             sub=row.row(align=True)



More information about the Bf-blender-cvs mailing list