[Bf-blender-cvs] [ddb71e8c20c] master: DRW: Remove is_negative_m4 per draw call

Clément Foucault noreply at git.blender.org
Mon May 6 22:33:26 CEST 2019


Commit: ddb71e8c20c2ceba61b4ebddc602adc5b8eed5c8
Author: Clément Foucault
Date:   Mon May 6 17:08:48 2019 +0200
Branches: master
https://developer.blender.org/rBddb71e8c20c2ceba61b4ebddc602adc5b8eed5c8

DRW: Remove is_negative_m4 per draw call

This had some cost in perf and is not needed most of the time. If the
drawcall really needs it, it should use a correct ob pointer.

===================================================================

M	source/blender/draw/intern/draw_manager_data.c

===================================================================

diff --git a/source/blender/draw/intern/draw_manager_data.c b/source/blender/draw/intern/draw_manager_data.c
index 8f324cf08cb..90ffdc194e0 100644
--- a/source/blender/draw/intern/draw_manager_data.c
+++ b/source/blender/draw/intern/draw_manager_data.c
@@ -400,7 +400,7 @@ static DRWCallState *drw_call_state_create(DRWShadingGroup *shgroup, float (*obm
   if (obmat != NULL) {
     copy_m4_m4(state->model, obmat);
 
-    if (is_negative_m4(state->model)) {
+    if (ob && (ob->transflag & OB_NEG_SCALE)) {
       state->flag |= DRW_CALL_NEGSCALE;
     }
   }



More information about the Bf-blender-cvs mailing list