[Bf-blender-cvs] [8b6afcb67b6] master: Cleanup: Eevee: Remove comment about vcol support in sculpt mode

Clément Foucault noreply at git.blender.org
Mon May 6 22:33:17 CEST 2019


Commit: 8b6afcb67b6ce4d7b28f01382b6b00b481dbc64e
Author: Clément Foucault
Date:   Sat May 4 15:23:53 2019 +0200
Branches: master
https://developer.blender.org/rB8b6afcb67b6ce4d7b28f01382b6b00b481dbc64e

Cleanup: Eevee: Remove comment about vcol support in sculpt mode

===================================================================

M	source/blender/draw/engines/eevee/eevee_materials.c

===================================================================

diff --git a/source/blender/draw/engines/eevee/eevee_materials.c b/source/blender/draw/engines/eevee/eevee_materials.c
index c55f3f0150c..c195732aaf8 100644
--- a/source/blender/draw/engines/eevee/eevee_materials.c
+++ b/source/blender/draw/engines/eevee/eevee_materials.c
@@ -1686,10 +1686,11 @@ void EEVEE_materials_cache_populate(EEVEE_Data *vedata,
       }
 
       if (is_sculpt_mode) {
-        /* TODO(fclem): Support Vcol. */
-        DRW_shgroup_call_sculpt_with_materials_add(shgrp_array, ma_array, ob, false);
-        DRW_shgroup_call_sculpt_with_materials_add(shgrp_depth_array, ma_array, ob, false);
-        DRW_shgroup_call_sculpt_with_materials_add(shgrp_depth_clip_array, ma_array, ob, false);
+        /* Vcol is not supported in the modes that require PBVH drawing. */
+        bool use_vcol = false;
+        DRW_shgroup_call_sculpt_with_materials_add(shgrp_array, ma_array, ob, use_vcol);
+        DRW_shgroup_call_sculpt_with_materials_add(shgrp_depth_array, ma_array, ob, use_vcol);
+        DRW_shgroup_call_sculpt_with_materials_add(shgrp_depth_clip_array, ma_array, ob, use_vcol);
         /* TODO(fclem): Support shadows in sculpt mode. */
       }
       else if (mat_geom) {



More information about the Bf-blender-cvs mailing list