[Bf-blender-cvs] [22c293f6d60] master: Cleanup: outdated comments, unused define

Campbell Barton noreply at git.blender.org
Thu May 2 10:25:59 CEST 2019


Commit: 22c293f6d606664ed459200905b9d87a772ec986
Author: Campbell Barton
Date:   Thu May 2 17:13:34 2019 +1000
Branches: master
https://developer.blender.org/rB22c293f6d606664ed459200905b9d87a772ec986

Cleanup: outdated comments, unused define

===================================================================

M	source/blender/makesdna/DNA_workspace_types.h

===================================================================

diff --git a/source/blender/makesdna/DNA_workspace_types.h b/source/blender/makesdna/DNA_workspace_types.h
index 1fd5e6a952a..2b5d81d02a0 100644
--- a/source/blender/makesdna/DNA_workspace_types.h
+++ b/source/blender/makesdna/DNA_workspace_types.h
@@ -25,9 +25,6 @@
 
 #include "DNA_scene_types.h"
 
-/* Currently testing, allow to disable. */
-#define USE_WORKSPACE_TOOL
-
 #
 #
 typedef struct bToolRef_Runtime {
@@ -114,14 +111,9 @@ typedef struct WorkSpace {
   /** #wmOwnerID. */
   ListBase owner_ids;
 
-  /* should be: '#ifdef USE_WORKSPACE_TOOL'. */
-
   /** List of #bToolRef */
   ListBase tools;
 
-  /**
-   * BAD DESIGN WARNING:
-   * This is a workaround for the topbar not knowing which tools spec. */
   char _pad[4];
 
   int object_mode;
@@ -129,10 +121,10 @@ typedef struct WorkSpace {
   /** Enum eWorkSpaceFlags. */
   int flags;
 
-  /* Number for workspace tab reordering in the UI. */
+  /** Number for workspace tab reordering in the UI. */
   int order;
 
-  /* Info text from modal operators (runtime). */
+  /** Info text from modal operators (runtime). */
   char *status_text;
 } WorkSpace;
 
@@ -162,10 +154,10 @@ typedef struct WorkSpace {
 typedef struct WorkSpaceDataRelation {
   struct WorkSpaceDataRelation *next, *prev;
 
-  /* the data used to identify the relation
-   * (e.g. to find screen-layout (= value) from/for a hook) */
+  /** The data used to identify the relation
+   * (e.g. to find screen-layout (= value) from/for a hook). */
   void *parent;
-  /* The value for this parent-data/workspace relation */
+  /** The value for this parent-data/workspace relation. */
   void *value;
 } WorkSpaceDataRelation;
 
@@ -177,7 +169,7 @@ typedef struct WorkSpaceInstanceHook {
   WorkSpace *active;
   struct WorkSpaceLayout *act_layout;
 
-  /* Needed because we can't change workspaces/layouts in running handler loop,
+  /** Needed because we can't change workspaces/layouts in running handler loop,
    * it would break context. */
   WorkSpace *temp_workspace_store;
   struct WorkSpaceLayout *temp_layout_store;



More information about the Bf-blender-cvs mailing list