[Bf-blender-cvs] [db4a5222495] master: Revert "RNA: error on register when classes use invalid identifiers"

Campbell Barton noreply at git.blender.org
Wed Mar 27 13:45:16 CET 2019


Commit: db4a5222495a95e50250b1a27a32f16487d1bcb8
Author: Campbell Barton
Date:   Wed Mar 27 23:29:42 2019 +1100
Branches: master
https://developer.blender.org/rBdb4a5222495a95e50250b1a27a32f16487d1bcb8

Revert "RNA: error on register when classes use invalid identifiers"

This reverts commit b24a255ca67841ff2d6121327791e933ce8e3602.

The warning wasn't being printed, so many add-ons weren't yet updated.

Re-enable now warnings are printed to allow addon developers to update.

===================================================================

M	source/blender/makesrna/intern/rna_access.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_access.c b/source/blender/makesrna/intern/rna_access.c
index 0c8183e795d..d72e6a5a9c9 100644
--- a/source/blender/makesrna/intern/rna_access.c
+++ b/source/blender/makesrna/intern/rna_access.c
@@ -1017,8 +1017,14 @@ bool RNA_struct_bl_idname_ok_or_report(ReportList *reports, const char *identifi
 	const int len_sep = strlen(sep);
 	const int len_id = strlen(identifier);
 	const char *p = strstr(identifier, sep);
+	/* TODO: make error, for now warning until add-ons update. */
+#if 1
+	const int report_level = RPT_WARNING;
+	const bool failure = true;
+#else
 	const int report_level = RPT_ERROR;
 	const bool failure = false;
+#endif
 	if (p == NULL || p == identifier || p + len_sep >= identifier + len_id) {
 		BKE_reportf(reports, report_level, "'%s' doesn't contain '%s' with prefix & suffix", identifier, sep);
 		return failure;



More information about the Bf-blender-cvs mailing list