[Bf-blender-cvs] [b24a255ca67] master: RNA: error on register when classes use invalid identifiers

Campbell Barton noreply at git.blender.org
Mon Mar 25 04:50:16 CET 2019


Commit: b24a255ca67841ff2d6121327791e933ce8e3602
Author: Campbell Barton
Date:   Mon Mar 25 14:39:55 2019 +1100
Branches: master
https://developer.blender.org/rBb24a255ca67841ff2d6121327791e933ce8e3602

RNA: error on register when classes use invalid identifiers

Ensure conventions are met since we're in beta and all instances should
be updated before release.

===================================================================

M	source/blender/makesrna/intern/rna_access.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_access.c b/source/blender/makesrna/intern/rna_access.c
index d72e6a5a9c9..0c8183e795d 100644
--- a/source/blender/makesrna/intern/rna_access.c
+++ b/source/blender/makesrna/intern/rna_access.c
@@ -1017,14 +1017,8 @@ bool RNA_struct_bl_idname_ok_or_report(ReportList *reports, const char *identifi
 	const int len_sep = strlen(sep);
 	const int len_id = strlen(identifier);
 	const char *p = strstr(identifier, sep);
-	/* TODO: make error, for now warning until add-ons update. */
-#if 1
-	const int report_level = RPT_WARNING;
-	const bool failure = true;
-#else
 	const int report_level = RPT_ERROR;
 	const bool failure = false;
-#endif
 	if (p == NULL || p == identifier || p + len_sep >= identifier + len_id) {
 		BKE_reportf(reports, report_level, "'%s' doesn't contain '%s' with prefix & suffix", identifier, sep);
 		return failure;



More information about the Bf-blender-cvs mailing list