[Bf-blender-cvs] [e25a0c4bb36] functions: remove dead code

Jacques Lucke noreply at git.blender.org
Wed Mar 20 19:33:42 CET 2019


Commit: e25a0c4bb36a64569f1477ec7db74bb9d88a993d
Author: Jacques Lucke
Date:   Wed Mar 20 19:11:23 2019 +0100
Branches: functions
https://developer.blender.org/rBe25a0c4bb36a64569f1477ec7db74bb9d88a993d

remove dead code

===================================================================

M	source/blender/functions/frontends/data_flow_nodes/test_nodes.cpp

===================================================================

diff --git a/source/blender/functions/frontends/data_flow_nodes/test_nodes.cpp b/source/blender/functions/frontends/data_flow_nodes/test_nodes.cpp
index ac5b80a333c..fa652e21bb3 100644
--- a/source/blender/functions/frontends/data_flow_nodes/test_nodes.cpp
+++ b/source/blender/functions/frontends/data_flow_nodes/test_nodes.cpp
@@ -71,17 +71,6 @@ namespace FN { namespace DataFlowNodes {
 		builder.map_output(min_node->output(0), bnode, 0);
 	}
 
-	static void insert_append_list_node(
-		Builder &builder,
-		const BuilderContext ctx,
-		bNode *bnode)
-	{
-		SharedType &base_type = ctx.type_from_rna(bnode, "active_type");
-		SharedFunction &fn = Functions::append_to_list(base_type);
-		Node *node = builder.insert_function(fn);
-		builder.map_sockets(node, bnode);
-	}
-
 	static void insert_get_list_element_node(
 		Builder &builder,
 		const BuilderContext ctx,
@@ -93,17 +82,6 @@ namespace FN { namespace DataFlowNodes {
 		builder.map_sockets(node, bnode);
 	}
 
-	static void insert_combine_lists_node(
-		Builder &builder,
-		const BuilderContext ctx,
-		bNode *bnode)
-	{
-		SharedType &base_type = ctx.type_from_rna(bnode, "active_type");
-		SharedFunction &fn = Functions::combine_lists(base_type);
-		Node *node = builder.insert_function(fn);
-		builder.map_sockets(node, bnode);
-	}
-
 	static void insert_pack_list_node(
 		Builder &builder,
 		const BuilderContext ctx,
@@ -111,13 +89,12 @@ namespace FN { namespace DataFlowNodes {
 	{
 		SharedType &base_type = ctx.type_from_rna(bnode, "active_type");
 
-		PointerRNA ptr;
-		ctx.get_rna(bnode, &ptr);
-		int input_amount = RNA_collection_length(&ptr, "variadic");
-
 		auto &empty_fn = Functions::empty_list(base_type);
 		Node *node = builder.insert_function(empty_fn);
 
+		PointerRNA ptr;
+		ctx.get_rna(bnode, &ptr);
+
 		int index = 0;
 		RNA_BEGIN(&ptr, itemptr, "variadic")
 		{
@@ -160,9 +137,7 @@ namespace FN { namespace DataFlowNodes {
 		inserters.reg_node_inserter("fn_ObjectTransformsNode", insert_object_transforms_node);
 		inserters.reg_node_inserter("fn_FloatMathNode", insert_float_math_node);
 		inserters.reg_node_inserter("fn_ClampNode", insert_clamp_node);
-		inserters.reg_node_inserter("fn_AppendToListNode", insert_append_list_node);
 		inserters.reg_node_inserter("fn_GetListElementNode", insert_get_list_element_node);
-		inserters.reg_node_inserter("fn_CombineListsNode", insert_combine_lists_node);
 		inserters.reg_node_inserter("fn_PackListNode", insert_pack_list_node);
 	}



More information about the Bf-blender-cvs mailing list