[Bf-blender-cvs] [d544a0b41c5] soc-2019-openxr: Avoid std::vector copy

Julian Eisel noreply at git.blender.org
Fri Jun 28 13:57:46 CEST 2019


Commit: d544a0b41c549e0ebb0058fbdcbcd88fb0e73636
Author: Julian Eisel
Date:   Fri Jun 28 13:56:10 2019 +0200
Branches: soc-2019-openxr
https://developer.blender.org/rBd544a0b41c549e0ebb0058fbdcbcd88fb0e73636

Avoid std::vector copy

===================================================================

M	intern/ghost/intern/GHOST_IXrGraphicsBinding.h
M	intern/ghost/intern/GHOST_XrGraphicsBinding.cpp

===================================================================

diff --git a/intern/ghost/intern/GHOST_IXrGraphicsBinding.h b/intern/ghost/intern/GHOST_IXrGraphicsBinding.h
index 6bb53b3b6ba..eca2c70cb52 100644
--- a/intern/ghost/intern/GHOST_IXrGraphicsBinding.h
+++ b/intern/ghost/intern/GHOST_IXrGraphicsBinding.h
@@ -40,7 +40,7 @@ class GHOST_IXrGraphicsBinding {
   } oxr_binding;
 
   virtual void initFromGhostContext(class GHOST_Context *ghost_ctx) = 0;
-  virtual bool chooseSwapchainFormat(std::vector<int64_t> runtime_formats,
+  virtual bool chooseSwapchainFormat(const std::vector<int64_t> &runtime_formats,
                                      int64_t *r_result) const = 0;
   virtual std::vector<XrSwapchainImageBaseHeader *> createSwapchainImages(
       uint32_t image_count) = 0;
diff --git a/intern/ghost/intern/GHOST_XrGraphicsBinding.cpp b/intern/ghost/intern/GHOST_XrGraphicsBinding.cpp
index 22f5e80c7ca..5a9a2b26959 100644
--- a/intern/ghost/intern/GHOST_XrGraphicsBinding.cpp
+++ b/intern/ghost/intern/GHOST_XrGraphicsBinding.cpp
@@ -75,7 +75,7 @@ class GHOST_XrGraphicsBindingOpenGL : public GHOST_IXrGraphicsBinding {
 #endif
   }
 
-  bool chooseSwapchainFormat(std::vector<int64_t> runtime_formats,
+  bool chooseSwapchainFormat(const std::vector<int64_t> &runtime_formats,
                              int64_t *r_result) const override
   {
     std::vector<int64_t> gpu_binding_formats = {GL_RGBA8};
@@ -127,7 +127,7 @@ class GHOST_XrGraphicsBindingD3D : public GHOST_IXrGraphicsBinding {
     m_ghost_ctx = ctx_d3d;
   }
 
-  bool chooseSwapchainFormat(std::vector<int64_t> runtime_formats,
+  bool chooseSwapchainFormat(const std::vector<int64_t> &runtime_formats,
                              int64_t *r_result) const override
   {
     std::vector<int64_t> gpu_binding_formats = {DXGI_FORMAT_R8G8B8A8_UNORM};



More information about the Bf-blender-cvs mailing list