[Bf-blender-cvs] [7a50d078fe4] master: Fix T64930: FFmpeg Output- no color mode by default

Sebastian Parborg noreply at git.blender.org
Wed Jun 12 15:20:24 CEST 2019


Commit: 7a50d078fe4125788dfb084cd23a5164070fe69b
Author: Sebastian Parborg
Date:   Wed Jun 12 15:16:30 2019 +0200
Branches: master
https://developer.blender.org/rB7a50d078fe4125788dfb084cd23a5164070fe69b

Fix T64930: FFmpeg Output- no color mode by default

The issue was that the valid color modes was checked on the old image
format, not the new one. So if you switched formats it would not
correctly check if the settings were valid.

===================================================================

M	source/blender/makesrna/intern/rna_scene.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_scene.c b/source/blender/makesrna/intern/rna_scene.c
index 16003815003..3e8b1807a98 100644
--- a/source/blender/makesrna/intern/rna_scene.c
+++ b/source/blender/makesrna/intern/rna_scene.c
@@ -1149,13 +1149,13 @@ static void rna_ImageFormatSettings_file_format_set(PointerRNA *ptr, int value)
 {
   ImageFormatData *imf = (ImageFormatData *)ptr->data;
   ID *id = ptr->id.data;
+  imf->imtype = value;
+
   const bool is_render = (id && GS(id->name) == ID_SCE);
   /* see note below on why this is */
   const char chan_flag = BKE_imtype_valid_channels(imf->imtype, true) |
                          (is_render ? IMA_CHAN_FLAG_BW : 0);
 
-  imf->imtype = value;
-
   /* ensure depth and color settings match */
   if (((imf->planes == R_IMF_PLANES_BW) && !(chan_flag & IMA_CHAN_FLAG_BW)) ||
       ((imf->planes == R_IMF_PLANES_RGBA) && !(chan_flag & IMA_CHAN_FLAG_ALPHA))) {



More information about the Bf-blender-cvs mailing list