[Bf-blender-cvs] [6c5ef425498] master: Fix T65505: crash applying modifiers in paint and sculpt modes

[Brecht Van Lommel]

Commit: 6c5ef4254981c899f6916da15a7b9a7af2e8310d
Author: Brecht Van Lommel
Date:   Thu Jun 6 18:44:03 2019 +0200
Branches: master
https://developer.blender.org/rB6c5ef4254981c899f6916da15a7b9a7af2e8310d

Fix T65505: crash applying modifiers in paint and sculpt modes

We need to find a better solution for mixing normal refreshes in some corner
cases. We actually had similar issues in 2.79 anyway, not crashing is more
important.

===================================================================

M	source/blender/blenkernel/intern/paint.c

===================================================================

diff --git a/source/blender/blenkernel/intern/paint.c b/source/blender/blenkernel/intern/paint.c
index f1f49070f1d..99ae19c3c30 100644
--- a/source/blender/blenkernel/intern/paint.c
+++ b/source/blender/blenkernel/intern/paint.c
@@ -992,11 +992,6 @@ static void sculptsession_free_pbvh(Object *object)
   SculptSession *ss = object->sculpt;
 
   if (ss && ss->pbvh) {
-    /* Ensure all normals are updated before freeing the PBVH, because
-     * we skip updating them for performance when we don't draw the PBVH. */
-    Mesh *mesh = object->data;
-    BKE_pbvh_update_normals(ss->pbvh, mesh->runtime.subdiv_ccg);
-
     BKE_pbvh_free(ss->pbvh);
     ss->pbvh = NULL;
   }