[Bf-blender-cvs] [9e249994514] blender-v2.80-release: Fix T67777: Linked rig crashes Blender 2.8 RC3 on File|New.

Bastien Montagne noreply at git.blender.org
Mon Jul 29 16:04:55 CEST 2019


Commit: 9e2499945147d687e3958a2ba35142fbdf8dd69c
Author: Bastien Montagne
Date:   Mon Jul 29 10:54:28 2019 +0200
Branches: blender-v2.80-release
https://developer.blender.org/rB9e2499945147d687e3958a2ba35142fbdf8dd69c

Fix T67777: Linked rig crashes Blender 2.8 RC3 on File|New.

Sync back between proxy armature pose and linked one was not properly
clearing the posebone runtime data, ending up with shared memory between
both (direct cause of reported crash), and probably some other nasty
issues.

While this crash is not critical in itself, I would suggest to add this
fix to 2.80 branch, as it is super-safe and simple, and is probably
fixing some other un-reported issues?

===================================================================

M	source/blender/blenkernel/intern/armature.c

===================================================================

diff --git a/source/blender/blenkernel/intern/armature.c b/source/blender/blenkernel/intern/armature.c
index c36acd1eae1..16ce03f1828 100644
--- a/source/blender/blenkernel/intern/armature.c
+++ b/source/blender/blenkernel/intern/armature.c
@@ -2374,6 +2374,9 @@ static void pose_proxy_synchronize(Object *ob, Object *from, int layer_protected
       pchanw.mpath = pchan->mpath;
       pchan->mpath = NULL;
 
+      /* Reset runtime data, we don't want to share that with the proxy. */
+      BKE_pose_channel_runtime_reset(&pchanw.runtime);
+
       /* this is freed so copy a copy, else undo crashes */
       if (pchanw.prop) {
         pchanw.prop = IDP_CopyProperty(pchanw.prop);



More information about the Bf-blender-cvs mailing list