[Bf-blender-cvs] [4b980e2f575] master: Fix T67196: bevel bad at a 3-edge bevel.

Howard Trickey noreply at git.blender.org
Sat Jul 20 14:40:38 CEST 2019


Commit: 4b980e2f5758f842e84fe15a97b8d570ca080ac0
Author: Howard Trickey
Date:   Sat Jul 20 08:38:41 2019 -0400
Branches: master
https://developer.blender.org/rB4b980e2f5758f842e84fe15a97b8d570ca080ac0

Fix T67196: bevel bad at a 3-edge bevel.

The test for whether or not this was a "pipe" neglected to use
fabsf() around a dot result.

===================================================================

M	source/blender/bmesh/tools/bmesh_bevel.c

===================================================================

diff --git a/source/blender/bmesh/tools/bmesh_bevel.c b/source/blender/bmesh/tools/bmesh_bevel.c
index c8338081443..90df3cd225e 100644
--- a/source/blender/bmesh/tools/bmesh_bevel.c
+++ b/source/blender/bmesh/tools/bmesh_bevel.c
@@ -3201,7 +3201,7 @@ static BoundVert *pipe_test(BevVert *bv)
   /* check face planes: all should have normals perpendicular to epipe */
   for (e = &bv->edges[0]; e != &bv->edges[bv->edgecount]; e++) {
     if (e->fnext) {
-      if (dot_v3v3(dir1, e->fnext->no) > BEVEL_EPSILON_BIG) {
+      if (fabsf(dot_v3v3(dir1, e->fnext->no)) > BEVEL_EPSILON_BIG) {
         return NULL;
       }
     }



More information about the Bf-blender-cvs mailing list