[Bf-blender-cvs] [70d193203bb] master: Fix T66668: frame selected bone not working in weight paint mode

Philipp Oeser noreply at git.blender.org
Mon Jul 15 16:23:01 CEST 2019


Commit: 70d193203bbac53a6c2992fbb5f87f4aa8465bb4
Author: Philipp Oeser
Date:   Mon Jul 15 16:20:11 2019 +0200
Branches: master
https://developer.blender.org/rB70d193203bbac53a6c2992fbb5f87f4aa8465bb4

Fix T66668: frame selected bone not working in weight paint mode

'viewselected_exec()' [which uses evaluated view layer] would query
BASE_SELECTED flag, but it was not set on base_eval, but on its
base_orig.

reason for this is 'ed_object_select_pick()' would modify base flags
[through 'ED_object_base_select()'], but not tag scene
ID_RECALC_BASE_FLAGS.

thx @sergey for hinting.

Reviewers: sergey, brecht

Maniphest Tasks: T66668

Differential Revision: https://developer.blender.org/D5235

===================================================================

M	source/blender/editors/space_view3d/view3d_select.c

===================================================================

diff --git a/source/blender/editors/space_view3d/view3d_select.c b/source/blender/editors/space_view3d/view3d_select.c
index fd7cc3d2ba2..0df5652c539 100644
--- a/source/blender/editors/space_view3d/view3d_select.c
+++ b/source/blender/editors/space_view3d/view3d_select.c
@@ -2319,6 +2319,7 @@ static bool ed_object_select_pick(bContext *C,
           retval = true;
           WM_event_add_notifier(C, NC_OBJECT | ND_BONE_SELECT, basact->object);
           WM_event_add_notifier(C, NC_OBJECT | ND_BONE_ACTIVE, basact->object);
+          DEG_id_tag_update(&scene->id, ID_RECALC_BASE_FLAGS);
 
           /* in weightpaint, we use selected bone to select vertexgroup,
            * so no switch to new active object */



More information about the Bf-blender-cvs mailing list