[Bf-blender-cvs] [c6d073f6a4e] master: Revert "Rename operator 'Join Shapes' to 'Transfer Mix'."

Brecht Van Lommel noreply at git.blender.org
Mon Jul 1 16:54:03 CEST 2019


Commit: c6d073f6a4e7e455b5891359e65fdffbb74a0887
Author: Brecht Van Lommel
Date:   Mon Jul 1 16:51:00 2019 +0200
Branches: master
https://developer.blender.org/rBc6d073f6a4e7e455b5891359e65fdffbb74a0887

Revert "Rename operator 'Join Shapes' to 'Transfer Mix'."

This reverts commit 741967079c393a9eb6babd60c92a716fafa5d3e9.
We are in UI and API freeze, and this changes both.

===================================================================

M	release/scripts/startup/bl_operators/object.py
M	release/scripts/startup/bl_ui/properties_data_mesh.py
M	source/blender/editors/object/object_add.c
M	source/blender/editors/object/object_intern.h
M	source/blender/editors/object/object_ops.c

===================================================================

diff --git a/release/scripts/startup/bl_operators/object.py b/release/scripts/startup/bl_operators/object.py
index 3c8fb1a4274..481b101eaee 100644
--- a/release/scripts/startup/bl_operators/object.py
+++ b/release/scripts/startup/bl_operators/object.py
@@ -312,9 +312,10 @@ class SubdivisionSet(Operator):
 
 
 class ShapeTransfer(Operator):
-    """Copy the active shape key of another selected object to this one"""
+    """Copy another selected objects active shape to this one by """ \
+        """applying the relative offsets"""
 
-    bl_idname = "object.shape_key_transfer_active"
+    bl_idname = "object.shape_key_transfer"
     bl_label = "Transfer Shape Key"
     bl_options = {'REGISTER', 'UNDO'}
 
diff --git a/release/scripts/startup/bl_ui/properties_data_mesh.py b/release/scripts/startup/bl_ui/properties_data_mesh.py
index 5be0a5dba37..e4fd09bb5ff 100644
--- a/release/scripts/startup/bl_ui/properties_data_mesh.py
+++ b/release/scripts/startup/bl_ui/properties_data_mesh.py
@@ -67,8 +67,8 @@ class MESH_MT_shape_key_context_menu(Menu):
         layout.operator("object.shape_key_mirror", icon='ARROW_LEFTRIGHT').use_topology = False
         layout.operator("object.shape_key_mirror", text="Mirror Shape Key (Topology)").use_topology = True
         layout.separator()
-        layout.operator("object.shape_key_transfer_mix")
-        layout.operator("object.shape_key_transfer_active")
+        layout.operator("object.join_shapes")
+        layout.operator("object.shape_key_transfer")
         layout.separator()
         layout.operator("object.shape_key_remove", icon='X', text="Delete All Shape Keys").all = True
         layout.separator()
diff --git a/source/blender/editors/object/object_add.c b/source/blender/editors/object/object_add.c
index 468efc0c9d9..0fdb1cec16f 100644
--- a/source/blender/editors/object/object_add.c
+++ b/source/blender/editors/object/object_add.c
@@ -2782,10 +2782,10 @@ void OBJECT_OT_join(wmOperatorType *ot)
 /** \} */
 
 /* -------------------------------------------------------------------- */
-/** \name Transfer Mix Operator for Shape Keys
+/** \name Join as Shape Key Operator
  * \{ */
 
-static bool shape_key_transfer_mix_poll(bContext *C)
+static bool join_shapes_poll(bContext *C)
 {
   Object *ob = CTX_data_active_object(C);
 
@@ -2802,12 +2802,12 @@ static bool shape_key_transfer_mix_poll(bContext *C)
   }
 }
 
-static int shape_key_transfer_mix_exec(bContext *C, wmOperator *op)
+static int join_shapes_exec(bContext *C, wmOperator *op)
 {
   Object *ob = CTX_data_active_object(C);
 
   if (ob->mode & OB_MODE_EDIT) {
-    BKE_report(op->reports, RPT_ERROR, "Shape Keys cannot be transfered in edit mode");
+    BKE_report(op->reports, RPT_ERROR, "This data does not support joining in edit mode");
     return OPERATOR_CANCELLED;
   }
   else if (BKE_object_obdata_is_libdata(ob)) {
@@ -2822,16 +2822,16 @@ static int shape_key_transfer_mix_exec(bContext *C, wmOperator *op)
   return OPERATOR_CANCELLED;
 }
 
-void OBJECT_OT_shape_key_transfer_mix(wmOperatorType *ot)
+void OBJECT_OT_join_shapes(wmOperatorType *ot)
 {
   /* identifiers */
-  ot->name = "Transfer Mix";
-  ot->description = "Copy the current resulting shape of another selected object to this one";
-  ot->idname = "OBJECT_OT_shape_key_transfer_mix";
+  ot->name = "Join as Shapes";
+  ot->description = "Merge selected objects to shapes of active object";
+  ot->idname = "OBJECT_OT_join_shapes";
 
   /* api callbacks */
-  ot->exec = shape_key_transfer_mix_exec;
-  ot->poll = shape_key_transfer_mix_poll;
+  ot->exec = join_shapes_exec;
+  ot->poll = join_shapes_poll;
 
   /* flags */
   ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
diff --git a/source/blender/editors/object/object_intern.h b/source/blender/editors/object/object_intern.h
index f97a9c1b5b8..b9350052093 100644
--- a/source/blender/editors/object/object_intern.h
+++ b/source/blender/editors/object/object_intern.h
@@ -117,7 +117,7 @@ void OBJECT_OT_duplicates_make_real(struct wmOperatorType *ot);
 void OBJECT_OT_duplicate(struct wmOperatorType *ot);
 void OBJECT_OT_delete(struct wmOperatorType *ot);
 void OBJECT_OT_join(struct wmOperatorType *ot);
-void OBJECT_OT_shape_key_transfer_mix(struct wmOperatorType *ot);
+void OBJECT_OT_join_shapes(struct wmOperatorType *ot);
 void OBJECT_OT_convert(struct wmOperatorType *ot);
 
 /* object_hook.c */
diff --git a/source/blender/editors/object/object_ops.c b/source/blender/editors/object/object_ops.c
index 217a2e5a54d..b653c7fa70c 100644
--- a/source/blender/editors/object/object_ops.c
+++ b/source/blender/editors/object/object_ops.c
@@ -117,7 +117,7 @@ void ED_operatortypes_object(void)
   WM_operatortype_append(OBJECT_OT_duplicates_make_real);
   WM_operatortype_append(OBJECT_OT_duplicate);
   WM_operatortype_append(OBJECT_OT_join);
-  WM_operatortype_append(OBJECT_OT_shape_key_transfer_mix);
+  WM_operatortype_append(OBJECT_OT_join_shapes);
   WM_operatortype_append(OBJECT_OT_convert);
 
   WM_operatortype_append(OBJECT_OT_modifier_add);



More information about the Bf-blender-cvs mailing list