[Bf-blender-cvs] [097b1cd08a5] master: Cleanup: remove immediate mode TODO
Campbell Barton
noreply at git.blender.org
Mon Jan 28 22:40:13 CET 2019
Commit: 097b1cd08a551c22df86c38c8d8380b87c88e81d
Author: Campbell Barton
Date: Tue Jan 29 08:40:46 2019 +1100
Branches: master
https://developer.blender.org/rB097b1cd08a551c22df86c38c8d8380b87c88e81d
Cleanup: remove immediate mode TODO
We've managed without these functions and can add them if needed,
this TODO isn't helping.
===================================================================
M source/blender/gpu/GPU_vertex_buffer.h
===================================================================
diff --git a/source/blender/gpu/GPU_vertex_buffer.h b/source/blender/gpu/GPU_vertex_buffer.h
index 721a455a6e2..f9405891f62 100644
--- a/source/blender/gpu/GPU_vertex_buffer.h
+++ b/source/blender/gpu/GPU_vertex_buffer.h
@@ -35,11 +35,13 @@
#include "GPU_vertex_format.h"
#define VRAM_USAGE 1
-/* How to create a GPUVertBuf: */
-/* 1) verts = GPU_vertbuf_create() or GPU_vertbuf_init(verts) */
-/* 2) GPU_vertformat_attr_add(verts->format, ...) */
-/* 3) GPU_vertbuf_data_alloc(verts, vertex_len) <-- finalizes/packs vertex format */
-/* 4) GPU_vertbuf_attr_fill(verts, pos, application_pos_buffer) */
+/**
+ * How to create a #GPUVertBuf:
+ * 1) verts = GPU_vertbuf_create() or GPU_vertbuf_init(verts)
+ * 2) GPU_vertformat_attr_add(verts->format, ...)
+ * 3) GPU_vertbuf_data_alloc(verts, vertex_len) <-- finalizes/packs vertex format
+ * 4) GPU_vertbuf_attr_fill(verts, pos, application_pos_buffer)
+ */
/* Is GPUVertBuf always used as part of a GPUBatch? */
@@ -117,17 +119,6 @@ GPU_INLINE uint GPU_vertbuf_raw_used(GPUVertBufRaw *a)
void GPU_vertbuf_attr_get_raw_data(GPUVertBuf *, uint a_idx, GPUVertBufRaw *access);
-/* TODO: decide whether to keep the functions below */
-/* doesn't immediate mode satisfy these needs? */
-
-/* void setAttrib1f(uint a_idx, uint v_idx, float x); */
-/* void setAttrib2f(uint a_idx, unsigned v_idx, float x, float y); */
-/* void setAttrib3f(unsigned a_idx, unsigned v_idx, float x, float y, float z); */
-/* void setAttrib4f(unsigned a_idx, unsigned v_idx, float x, float y, float z, float w); */
-
-/* void setAttrib3ub(unsigned a_idx, unsigned v_idx, unsigned char r, unsigned char g, unsigned char b); */
-/* void setAttrib4ub(unsigned a_idx, unsigned v_idx, unsigned char r, unsigned char g, unsigned char b, unsigned char a); */
-
void GPU_vertbuf_use(GPUVertBuf *);
/* Metrics */
More information about the Bf-blender-cvs
mailing list