[Bf-blender-cvs] [3f0a26137aa] blender2.7: Spin Tool: don't flip when using a negative angle

Campbell Barton noreply at git.blender.org
Fri Jan 4 07:08:17 CET 2019


Commit: 3f0a26137aac348a2b5660de0769a923160d9a7f
Author: Campbell Barton
Date:   Fri Jan 4 16:17:49 2019 +1100
Branches: blender2.7
https://developer.blender.org/rB3f0a26137aac348a2b5660de0769a923160d9a7f

Spin Tool: don't flip when using a negative angle

The intention was to flip normals when extruding in the opposite
direction, however the sign of the angle isn't meaningful unless
the geometry center and region normal are taken into account.

Disable, may add back in a way that works more predictably.

===================================================================

M	source/blender/editors/mesh/editmesh_extrude_spin.c

===================================================================

diff --git a/source/blender/editors/mesh/editmesh_extrude_spin.c b/source/blender/editors/mesh/editmesh_extrude_spin.c
index a9e78f74012..b7c09c2b029 100644
--- a/source/blender/editors/mesh/editmesh_extrude_spin.c
+++ b/source/blender/editors/mesh/editmesh_extrude_spin.c
@@ -66,7 +66,7 @@ static int edbm_spin_exec(bContext *C, wmOperator *op)
 	RNA_float_get_array(op->ptr, "axis", axis);
 	const int steps = RNA_int_get(op->ptr, "steps");
 	const float angle = RNA_float_get(op->ptr, "angle");
-	const bool use_normal_flip = RNA_boolean_get(op->ptr, "use_normal_flip") ^ (angle < 0.0f);
+	const bool use_normal_flip = RNA_boolean_get(op->ptr, "use_normal_flip");
 	const bool dupli = RNA_boolean_get(op->ptr, "dupli");
 	const bool use_auto_merge = (
 	        RNA_boolean_get(op->ptr, "use_auto_merge") &&



More information about the Bf-blender-cvs mailing list