[Bf-blender-cvs] [d2c941def33] master: DRW: remove INDEX4 normal flipping
Campbell Barton
noreply at git.blender.org
Thu Jan 3 07:29:02 CET 2019
Commit: d2c941def337e25ceb4e1c268e97176645d2c348
Author: Campbell Barton
Date: Thu Jan 3 17:20:41 2019 +1100
Branches: master
https://developer.blender.org/rBd2c941def337e25ceb4e1c268e97176645d2c348
DRW: remove INDEX4 normal flipping
Added in 531e5ad49a03763 but I couldn't find a case when it's needed,
It's not needed for solid-mode viewport drawing for eg.
===================================================================
M source/blender/draw/intern/draw_cache_impl_displist.c
===================================================================
diff --git a/source/blender/draw/intern/draw_cache_impl_displist.c b/source/blender/draw/intern/draw_cache_impl_displist.c
index 73736cbe9c6..e553297e514 100644
--- a/source/blender/draw/intern/draw_cache_impl_displist.c
+++ b/source/blender/draw/intern/draw_cache_impl_displist.c
@@ -509,7 +509,7 @@ void DRW_displist_vertbuf_create_pos_and_nor_and_uv_tess(
if (is_smooth) {
int idx_len = is_tri ? 3 : 4;
for (int j = 0; j < idx_len; j++) {
- pnors_idx[j] = GPU_normal_convert_i10_v3_negated(nors[idx[j]]);
+ pnors_idx[j] = GPU_normal_convert_i10_v3(nors[idx[j]]);
}
}
else {
@@ -520,7 +520,7 @@ void DRW_displist_vertbuf_create_pos_and_nor_and_uv_tess(
else {
normal_quad_v3(nor_flat, verts[idx[0]], verts[idx[1]], verts[idx[2]], verts[idx[3]]);
}
- pnors_idx[0] = GPU_normal_convert_i10_v3_negated(nor_flat);
+ pnors_idx[0] = GPU_normal_convert_i10_v3(nor_flat);
pnors_idx[1] = pnors_idx[0];
pnors_idx[2] = pnors_idx[0];
pnors_idx[3] = pnors_idx[0];
More information about the Bf-blender-cvs
mailing list