[Bf-blender-cvs] [872ff507a26] master: Fix Spring characters being in the rest pose on file open

Sergey Sharybin noreply at git.blender.org
Fri Feb 15 10:56:59 CET 2019


Commit: 872ff507a26c73b0c474019ebe86358aa9601292
Author: Sergey Sharybin
Date:   Fri Feb 15 10:54:46 2019 +0100
Branches: master
https://developer.blender.org/rB872ff507a26c73b0c474019ebe86358aa9601292

Fix Spring characters being in the rest pose on file open

This partially reverts bf2c5217 and makes it so animation is evaluated
for datablocks which were never evaluated within the dependency graph.

Not ideal, but safest way currently.

Animation for already evaluated datablocks will only be evaluated on
manual edits, so the initial bugfix is still valid.

===================================================================

M	source/blender/depsgraph/intern/depsgraph_tag.cc

===================================================================

diff --git a/source/blender/depsgraph/intern/depsgraph_tag.cc b/source/blender/depsgraph/intern/depsgraph_tag.cc
index 53697a8aabd..454b622385a 100644
--- a/source/blender/depsgraph/intern/depsgraph_tag.cc
+++ b/source/blender/depsgraph/intern/depsgraph_tag.cc
@@ -484,6 +484,13 @@ void deg_graph_on_visible_update(Main *bmain, Depsgraph *graph)
 		int flag = 0;
 		if (!DEG::deg_copy_on_write_is_expanded(id_node->id_cow)) {
 			flag |= ID_RECALC_COPY_ON_WRITE;
+			/* TODO(sergey): Shouldn't be needed, but currently we are lackign
+			 * some flushing of evaluated data to the original one, which makes,
+			 * for example, files saved with the rest pose.
+			 * Need to solve those issues carefully, for until then we evaluate
+			 * animation for datablocks which appears in the graph for the first
+			 * time. */
+			flag |= ID_RECALC_ANIMATION;
 		}
 		/* We only tag components which needs an update. Tagging everything is
 		 * not a good idea because that might reset particles cache (or any



More information about the Bf-blender-cvs mailing list