[Bf-blender-cvs] [9574ac1c8d9] master: LibOverride: Disable the re-parenting of overriding objects to the instancing empty.

[Bastien Montagne]

Commit: 9574ac1c8d9c5c9d370b7d95eec7c657105e0658
Author: Bastien Montagne
Date:   Fri Aug 23 18:56:48 2019 +0200
Branches: master
https://developer.blender.org/rB9574ac1c8d9c5c9d370b7d95eec7c657105e0658

LibOverride: Disable the re-parenting of overriding objects to the instancing empty.

Does not seems to be that useful... And it's breaking the objects also
'parented' to an armature through a modifier...

===================================================================

M	source/blender/editors/object/object_relations.c

===================================================================

diff --git a/source/blender/editors/object/object_relations.c b/source/blender/editors/object/object_relations.c
index eb6688b915a..739f05e0b67 100644
--- a/source/blender/editors/object/object_relations.c
+++ b/source/blender/editors/object/object_relations.c
@@ -2471,7 +2471,11 @@ static int make_override_library_exec(bContext *C, wmOperator *op)
           DEG_id_tag_update_ex(bmain, &new_ob->id, ID_RECALC_TRANSFORM | ID_RECALC_BASE_FLAGS);
         }
         /* parent to 'collection' empty */
-        if (new_ob->parent == NULL) {
+        /* Disabled for now, according to some artist this is probably not really useful anyway.
+         * And it breaks things like objects parented to bones
+         * (most likely due to missing proper setting of inverse parent matrix?)... */
+        /* Note: we might even actually want to get rid of that instanciating empty... */
+        if (0 && new_ob->parent == NULL) {
           new_ob->parent = obcollection;
         }
         if (new_ob == (Object *)obact->id.newid) {