[Bf-blender-cvs] [9bc10c1f542] master: Cleanup: remove comment to workaround weak code parsing

Campbell Barton noreply at git.blender.org
Wed Aug 14 17:40:14 CEST 2019


Commit: 9bc10c1f542d3fee601ea35536a3375367cf3652
Author: Campbell Barton
Date:   Thu Aug 15 01:05:15 2019 +1000
Branches: master
https://developer.blender.org/rB9bc10c1f542d3fee601ea35536a3375367cf3652

Cleanup: remove comment to workaround weak code parsing

This is quite an old comment, recent IDE's/editors
should be able to handle escaped quotes in strings.

If kludges like this are needed, developers should note exactly why.

===================================================================

M	source/blender/blenkernel/intern/action.c

===================================================================

diff --git a/source/blender/blenkernel/intern/action.c b/source/blender/blenkernel/intern/action.c
index 57a7379eeae..d072a0aa599 100644
--- a/source/blender/blenkernel/intern/action.c
+++ b/source/blender/blenkernel/intern/action.c
@@ -1420,9 +1420,7 @@ short action_get_item_transforms(bAction *act, Object *ob, bPoseChannel *pchan,
 
       if ((curves) || (flags & ACT_TRANS_PROP) == 0) {
         /* custom properties only */
-        pPtr = strstr(
-            bPtr,
-            "[\""); /* extra '"' comment here to keep my texteditor functionlist working :) */
+        pPtr = strstr(bPtr, "[\"");
         if (pPtr) {
           flags |= ACT_TRANS_PROP;



More information about the Bf-blender-cvs mailing list