[Bf-blender-cvs] [63c463ac458] master: Docs: improve comments

Campbell Barton noreply at git.blender.org
Sun Aug 11 14:42:11 CEST 2019


Commit: 63c463ac458fda7a14f8e9f217c5cba7426aa4a8
Author: Campbell Barton
Date:   Sun Aug 11 22:34:22 2019 +1000
Branches: master
https://developer.blender.org/rB63c463ac458fda7a14f8e9f217c5cba7426aa4a8

Docs: improve comments

===================================================================

M	source/blender/editors/space_view3d/view3d_fly.c
M	source/blender/editors/space_view3d/view3d_walk.c
M	source/blender/editors/uvedit/uvedit_ops.c

===================================================================

diff --git a/source/blender/editors/space_view3d/view3d_fly.c b/source/blender/editors/space_view3d/view3d_fly.c
index 3e2e113be3e..01828824e8d 100644
--- a/source/blender/editors/space_view3d/view3d_fly.c
+++ b/source/blender/editors/space_view3d/view3d_fly.c
@@ -155,7 +155,13 @@ typedef struct FlyInfo {
    * without moving the direction there looking */
   bool use_freelook;
 
-  bool anim_playing; /* needed for autokeyframing */
+  /**
+   * Needed for auto-keyframing, when animation isn't playing, only keyframe on confirmation.
+   *
+   * Currently we can't cancel this operator usefully while recording on animation playback
+   * (this would need to un-key all previous frames).
+   */
+  bool anim_playing;
 
   int mval[2];         /* latest 2D mouse values */
   int center_mval[2];  /* center mouse values */
diff --git a/source/blender/editors/space_view3d/view3d_walk.c b/source/blender/editors/space_view3d/view3d_walk.c
index 22c1aafd7c4..4b2e9d974b9 100644
--- a/source/blender/editors/space_view3d/view3d_walk.c
+++ b/source/blender/editors/space_view3d/view3d_walk.c
@@ -196,7 +196,13 @@ typedef struct WalkInfo {
   short state;
   bool redraw;
 
-  bool anim_playing; /* needed for autokeyframing */
+  /**
+   * Needed for auto-keyframing, when animation isn't playing, only keyframe on confirmation.
+   *
+   * Currently we can't cancel this operator usefully while recording on animation playback
+   * (this would need to un-key all previous frames).
+   */
+  bool anim_playing;
 
   int prev_mval[2];   /* previous 2D mouse values */
   int center_mval[2]; /* center mouse values */
diff --git a/source/blender/editors/uvedit/uvedit_ops.c b/source/blender/editors/uvedit/uvedit_ops.c
index 883671949c8..dcf1d04ffb3 100644
--- a/source/blender/editors/uvedit/uvedit_ops.c
+++ b/source/blender/editors/uvedit/uvedit_ops.c
@@ -4519,7 +4519,9 @@ static int uv_select_overlap(bContext *C, const bool extend)
       const float(*t1)[2] = o_a->tri;
       const float(*t2)[2] = o_b->tri;
       float vi[2];
-      bool result =
+      bool result = (
+          /* Don't use 'isect_tri_tri_v2' here
+           * because it's important to ignore overlap at end-points. */
           isect_seg_seg_v2_point_ex(t1[0], t1[1], t2[0], t2[1], endpoint_bias, vi) == 1 ||
           isect_seg_seg_v2_point_ex(t1[0], t1[1], t2[1], t2[2], endpoint_bias, vi) == 1 ||
           isect_seg_seg_v2_point_ex(t1[0], t1[1], t2[2], t2[0], endpoint_bias, vi) == 1 ||
@@ -4529,7 +4531,7 @@ static int uv_select_overlap(bContext *C, const bool extend)
           isect_seg_seg_v2_point_ex(t1[2], t1[0], t2[0], t2[1], endpoint_bias, vi) == 1 ||
           isect_seg_seg_v2_point_ex(t1[2], t1[0], t2[1], t2[2], endpoint_bias, vi) == 1 ||
           isect_point_tri_v2(t1[0], t2[0], t2[1], t2[2]) != 0 ||
-          isect_point_tri_v2(t2[0], t1[0], t1[1], t1[2]) != 0;
+          isect_point_tri_v2(t2[0], t1[0], t1[1], t1[2]) != 0);
 
       if (result) {
         uvedit_face_select_enable(scene, em_a, face_a, false, cd_loop_uv_offset_a);



More information about the Bf-blender-cvs mailing list