[Bf-blender-cvs] [7d6a9b55175] master: Cleanup: style, use braces
Campbell Barton
noreply at git.blender.org
Mon Apr 22 13:15:44 CEST 2019
Commit: 7d6a9b551759cf3f1cca0c6d8ecb1459d02dcc28
Author: Campbell Barton
Date: Mon Apr 22 12:20:14 2019 +1000
Branches: master
https://developer.blender.org/rB7d6a9b551759cf3f1cca0c6d8ecb1459d02dcc28
Cleanup: style, use braces
Add braces for modules already using braces almost everywhere.
===================================================================
M source/blender/alembic/intern/abc_mesh.cc
M source/blender/alembic/intern/alembic_capi.cc
M source/blender/blenlib/intern/fileops.c
M source/blender/blentranslation/intern/blt_lang.c
M source/blender/blentranslation/msgfmt/msgfmt.c
M source/blender/bmesh/tools/bmesh_bevel.c
M source/blender/datatoc/datatoc.c
M source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc
M source/blender/depsgraph/intern/depsgraph_debug.cc
M source/blender/draw/intern/draw_cache_impl_mesh.c
M source/blender/draw/intern/draw_manager.c
M source/blender/imbuf/intern/allocimbuf.c
===================================================================
diff --git a/source/blender/alembic/intern/abc_mesh.cc b/source/blender/alembic/intern/abc_mesh.cc
index 5ccb9be02a3..34d7e8847b1 100644
--- a/source/blender/alembic/intern/abc_mesh.cc
+++ b/source/blender/alembic/intern/abc_mesh.cc
@@ -373,8 +373,9 @@ void AbcGenericMeshWriter::setIsAnimated(bool is_animated)
void AbcGenericMeshWriter::do_write()
{
/* We have already stored a sample for this object. */
- if (!m_first_frame && !m_is_animated)
+ if (!m_first_frame && !m_is_animated) {
return;
+ }
bool needsfree;
struct Mesh *mesh = getFinalMesh(needsfree);
@@ -387,12 +388,14 @@ void AbcGenericMeshWriter::do_write()
writeMesh(mesh);
}
- if (needsfree)
+ if (needsfree) {
freeEvaluatedMesh(mesh);
+ }
}
catch (...) {
- if (needsfree)
+ if (needsfree) {
freeEvaluatedMesh(mesh);
+ }
throw;
}
}
diff --git a/source/blender/alembic/intern/alembic_capi.cc b/source/blender/alembic/intern/alembic_capi.cc
index 0bc4eb2385b..aac7a7f2d82 100644
--- a/source/blender/alembic/intern/alembic_capi.cc
+++ b/source/blender/alembic/intern/alembic_capi.cc
@@ -787,8 +787,9 @@ static void import_endjob(void *user_data)
/* It's possible that cancellation occurred between the creation of
* the reader and the creation of the Blender object. */
- if (ob == NULL)
+ if (ob == NULL) {
continue;
+ }
BKE_id_free_us(data->bmain, ob);
}
diff --git a/source/blender/blenlib/intern/fileops.c b/source/blender/blenlib/intern/fileops.c
index f8a34404cc7..8fff9603a88 100644
--- a/source/blender/blenlib/intern/fileops.c
+++ b/source/blender/blenlib/intern/fileops.c
@@ -70,11 +70,13 @@ int BLI_file_gzip(const char *from, const char *to)
/* level 1 is very close to 3 (the default) in terms of file size,
* but about twice as fast, best use for speedy saving - campbell */
gzfile = BLI_gzopen(to, "wb1");
- if (gzfile == NULL)
+ if (gzfile == NULL) {
return -1;
+ }
file = BLI_open(from, O_BINARY | O_RDONLY, 0);
- if (file == -1)
+ if (file == -1) {
return -2;
+ }
while (1) {
readsize = read(file, buffer, sizeof(buffer));
@@ -84,8 +86,9 @@ int BLI_file_gzip(const char *from, const char *to)
fprintf(stderr, "Error reading file %s: %s.\n", from, strerror(errno));
break;
}
- else if (readsize == 0)
+ else if (readsize == 0) {
break; /* done reading */
+ }
if (gzwrite(gzfile, buffer, readsize) <= 0) {
rval = -1; /* error happened in writing */
@@ -946,8 +949,9 @@ static int move_callback_pre(const char *from, const char *to)
{
int ret = rename(from, to);
- if (ret)
+ if (ret) {
return copy_callback_pre(from, to);
+ }
return RecursiveOp_Callback_StopRecurs;
}
@@ -956,8 +960,9 @@ static int move_single_file(const char *from, const char *to)
{
int ret = rename(from, to);
- if (ret)
+ if (ret) {
return copy_single_file(from, to);
+ }
return RecursiveOp_Callback_OK;
}
diff --git a/source/blender/blentranslation/intern/blt_lang.c b/source/blender/blentranslation/intern/blt_lang.c
index 52d15a29fc2..75a4681deb2 100644
--- a/source/blender/blentranslation/intern/blt_lang.c
+++ b/source/blender/blentranslation/intern/blt_lang.c
@@ -108,8 +108,9 @@ static void fill_locales(void)
continue; /* Comment or void... */
}
t = atoi(str);
- if (t >= num_locales)
+ if (t >= num_locales) {
num_locales = t + 1;
+ }
num_locales_menu++;
line = line->next;
}
@@ -261,8 +262,9 @@ void BLT_lang_set(const char *str)
const char *short_locale = str ? str : LOCALE(ulang);
const char *short_locale_utf8 = NULL;
- if ((U.transopts & USER_DOTRANSLATE) == 0)
+ if ((U.transopts & USER_DOTRANSLATE) == 0) {
return;
+ }
/* We want to avoid locales like '.UTF-8'! */
if (short_locale[0]) {
@@ -331,36 +333,45 @@ void BLT_lang_locale_explode(const char *locale,
if (language || language_variant) {
if (m1 || m2) {
_t = m1 ? BLI_strdupn(locale, m1 - locale) : BLI_strdupn(locale, m2 - locale);
- if (language)
+ if (language) {
*language = _t;
+ }
}
else if (language) {
*language = BLI_strdup(locale);
}
}
if (country) {
- if (m1)
+ if (m1) {
*country = m2 ? BLI_strdupn(m1 + 1, m2 - (m1 + 1)) : BLI_strdup(m1 + 1);
- else
+ }
+ else {
*country = NULL;
+ }
}
if (variant) {
- if (m2)
+ if (m2) {
*variant = BLI_strdup(m2 + 1);
- else
+ }
+ else {
*variant = NULL;
+ }
}
if (language_country) {
- if (m1)
+ if (m1) {
*language_country = m2 ? BLI_strdupn(locale, m2 - locale) : BLI_strdup(locale);
- else
+ }
+ else {
*language_country = NULL;
+ }
}
if (language_variant) {
- if (m2)
+ if (m2) {
*language_variant = m1 ? BLI_strdupcat(_t, m2) : BLI_strdup(locale);
- else
+ }
+ else {
*language_variant = NULL;
+ }
}
if (_t && !language) {
MEM_freeN(_t);
diff --git a/source/blender/blentranslation/msgfmt/msgfmt.c b/source/blender/blentranslation/msgfmt/msgfmt.c
index 4ab0bd29a5f..500ae2df4b5 100644
--- a/source/blender/blentranslation/msgfmt/msgfmt.c
+++ b/source/blender/blentranslation/msgfmt/msgfmt.c
@@ -82,12 +82,15 @@ static char *trim(char *str)
return str;
}
- for (i = 0; i < len && ELEM(str[0], ' ', '\t', '\n'); str++, i++)
- ;
+ for (i = 0; i < len && ELEM(str[0], ' ', '\t', '\n'); str++, i++) {
+ /* pass */
+ }
char *end = &str[len - 1 - i];
- for (i = len; i > 0 && ELEM(end[0], ' ', '\t', '\n'); end--, i--)
- ;
+ for (i = len; i > 0 && ELEM(end[0], ' ', '\t', '\n'); end--, i--) {
+ /* pass */
+ }
+
end[1] = '\0';
return str;
diff --git a/source/blender/bmesh/tools/bmesh_bevel.c b/source/blender/bmesh/tools/bmesh_bevel.c
index 2c304d790df..3cb4cbfdf41 100644
--- a/source/blender/bmesh/tools/bmesh_bevel.c
+++ b/source/blender/bmesh/tools/bmesh_bevel.c
@@ -2990,11 +2990,13 @@ static void adjust_offsets(BevelParams *bp, BMesh *bm)
/* find and process chains and cycles of unvisited BoundVerts that have eon set */
/* note: for repeatability, iterate over all verts of mesh rather than over ghash'ed BMVerts */
BM_ITER_MESH (bmv, &iter, bm, BM_VERTS_OF_MESH) {
- if (!BM_elem_flag_test(bmv, BM_ELEM_TAG))
+ if (!BM_elem_flag_test(bmv, BM_ELEM_TAG)) {
continue;
+ }
bv = bvcur = find_bevvert(bp, bmv);
- if (!bv)
+ if (!bv) {
continue;
+ }
vanchor = bv->vmesh->boundstart;
do {
if (vanchor->visited || !vanchor->eon) {
@@ -3068,8 +3070,9 @@ static void adjust_offsets(BevelParams *bp, BMesh *bm)
BM_ITER_MESH (bmv, &iter, bm, BM_VERTS_OF_MESH) {
if (BM_elem_flag_test(bmv, BM_ELEM_TAG)) {
bv = find_bevvert(bp, bmv);
- if (bv)
+ if (bv) {
build_boundary(bp, bv, false);
+ }
}
}
}
@@ -6357,11 +6360,13 @@ static void bevel_limit_offset(BevelParams *bp, BMesh *bm)
limited_offset = bp->offset;
BM_ITER_MESH (bmv, &iter, bm, BM_VERTS_OF_MESH) {
- if (!BM_elem_flag_test(bmv, BM_ELEM_TAG))
+ if (!BM_elem_flag_test(bmv, BM_ELEM_TAG)) {
continue;
+ }
bv = find_bevvert(bp, bmv);
- if (!bv)
+ if (!bv) {
continue;
+ }
for (i = 0; i < bv->edgecount; i++) {
eh = &bv->edges[i];
if (bp->vertex_only) {
@@ -6387,11 +6392,13 @@ static void bevel_limit_offset(BevelParams *bp, BMesh *bm)
*/
offset_factor = limited_offset / bp->offset;
BM_ITER_MESH (bmv, &iter, bm, BM_VERTS_OF_MESH) {
- if (!BM_elem_flag_test(bmv, BM_ELEM_TAG))
+ if (!BM_elem_flag_test(bmv, BM_ELEM_TAG)) {
continue;
+ }
bv = find_bevvert(bp, bmv);
- if (!bv)
+ if (!bv) {
continue;
+ }
for (i = 0; i < bv->edgecount; i++) {
eh = &bv->edges[i];
eh->offset_l_spec *= offset_factor;
@@ -6500,8 +6507,9 @@ void BM_mesh_bevel(BMesh *bm,
BM_ITER_MESH (v, &iter, bm, BM_VERTS_OF_MESH) {
if (BM_elem_flag_test(v, BM_ELEM_TAG)) {
bv = find_bevvert(&bp, v);
- if (bv)
+ if (bv) {
build_boundary(&bp, bv, true);
+ }
}
}
}
@@ -6534,8 +6542,9 @@ void BM_mesh_bevel(BMesh *bm,
BM_ITER_MESH (v, &iter, bm, BM_VERTS_OF_MESH) {
if (BM_elem_flag_test(v, BM_ELEM_TAG)) {
bv = find_bevvert(&bp, v);
- if (bv)
+ if (bv) {
bevel_extend_edge_data(bv);
+ }
}
}
diff --git a/source/blender/datatoc/datatoc.c b/source/blender/datatoc/datatoc.c
index 7a180b0912d..6fe2650d66c 100644
--- a/source/blender/datatoc/datatoc.c
+++ b/source/blender/datatoc/datatoc.c
@@ -80,8 +80,9 @@ int main(int argc, char **argv)
argv_len = (int)strlen(argv[1]);
for (i = 0; i < argv_len; i++) {
- if (argv[1][i] == '.')
+ if (argv[1][i] == '.') {
argv[1][i] = '_';
+ }
}
fpout = fopen(argv[2], "w");
diff --git a/source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc b/source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc
index abd3b398cb7..068a04943e6 100644
--- a/source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc
+++ b/source/blender/depsgraph/intern/debug/deg_debug_relations_graphviz.cc
@@ -122,8 +122,9 @@ static int deg_debug_node_color_index(const Node *node)
return 5;
case NodeType::OPERATION: {
OperationNode *op_node = (OperationNode *)node;
- if (op_node->is_noop())
+ if (op_node->is_noop()) {
return 8;
+ }
break;
}
@@ -485,16 +486,19 @@ static bool deg_debug_graphviz_is_owner(const Node *node, const Node *other)
switch (node->get_class()) {
case NodeClass::COMPONENT: {
ComponentNode *comp_node = (ComponentNode *)node;
- if (comp_node->owner == other)
+ if (comp_node->owner == other) {
return true;
+ }
break;
}
case NodeClass::OPERATION: {
OperationNode *op_node = (OperationNode *)node;
- if (op_node->owner == other)
+ if (op_node->owner == other) {
return true;
-
@@ Diff output truncated at 10240 characters. @@
More information about the Bf-blender-cvs
mailing list