[Bf-blender-cvs] [00b966b83ac] master: Explain the Local With Parent coordinate space better.

Alexander Gavrilov noreply at git.blender.org
Sun Apr 14 15:29:04 CEST 2019


Commit: 00b966b83ac6277e2b33e976458279e954e52f45
Author: Alexander Gavrilov
Date:   Sun Apr 14 16:26:47 2019 +0300
Branches: master
https://developer.blender.org/rB00b966b83ac6277e2b33e976458279e954e52f45

Explain the Local With Parent coordinate space better.

Just saying "parent transformation added" doesn't really explain
what this coordinate space does. Thus it seems almost nobody used
it and serious bugs like T61981 went unnoticed.

===================================================================

M	source/blender/makesrna/intern/rna_constraint.c
M	source/blender/makesrna/intern/rna_object_api.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_constraint.c b/source/blender/makesrna/intern/rna_constraint.c
index 4c6c7740ff8..bd7f75f86b5 100644
--- a/source/blender/makesrna/intern/rna_constraint.c
+++ b/source/blender/makesrna/intern/rna_constraint.c
@@ -115,8 +115,8 @@ static const EnumPropertyItem target_space_pchan_items[] = {
 	                            "The transformation of the target is only evaluated in the Pose Space, "
 	                            "the target armature object transformation is ignored"},
 	{CONSTRAINT_SPACE_PARLOCAL, "LOCAL_WITH_PARENT", 0, "Local With Parent",
-	                            "The transformation of the target bone is evaluated relative its local "
-	                            "coordinate system, with the parent transformation added"},
+	                            "The transformation of the target bone is evaluated relative to its rest pose "
+	                            "local coordinate system, thus including the parent-induced transformation"},
 	{CONSTRAINT_SPACE_LOCAL,    "LOCAL", 0, "Local Space",
 	                            "The transformation of the target is evaluated relative to its local "
 	                            "coordinate system"},
@@ -129,8 +129,8 @@ static const EnumPropertyItem owner_space_pchan_items[] = {
 	{CONSTRAINT_SPACE_POSE,     "POSE", 0, "Pose Space",
 	                            "The constraint is applied in Pose Space, the object transformation is ignored"},
 	{CONSTRAINT_SPACE_PARLOCAL, "LOCAL_WITH_PARENT", 0, "Local With Parent",
-	                            "The constraint is applied relative to the local coordinate system of the object, "
-	                            "with the parent transformation added"},
+	                            "The constraint is applied relative to the rest pose local coordinate system "
+	                            "of the bone, thus including the parent-induced transformation"},
 	{CONSTRAINT_SPACE_LOCAL,    "LOCAL", 0, "Local Space",
 	                            "The constraint is applied relative to the local coordinate system of the object"},
 	{0, NULL, 0, NULL, NULL},
diff --git a/source/blender/makesrna/intern/rna_object_api.c b/source/blender/makesrna/intern/rna_object_api.c
index 5e90f1feddf..68b8d1b2a5f 100644
--- a/source/blender/makesrna/intern/rna_object_api.c
+++ b/source/blender/makesrna/intern/rna_object_api.c
@@ -49,7 +49,7 @@ static const EnumPropertyItem space_items[] = {
 	{CONSTRAINT_SPACE_POSE,     "POSE", 0, "Pose Space",
 	                            "The pose space of a bone (its armature's object space)"},
 	{CONSTRAINT_SPACE_PARLOCAL, "LOCAL_WITH_PARENT", 0, "Local With Parent",
-	                            "The local space of a bone's parent bone"},
+	                            "The rest pose local space of a bone (thus matrix includes parent transforms)"},
 	{CONSTRAINT_SPACE_LOCAL,    "LOCAL", 0, "Local Space",
 	                            "The local space of an object/bone"},
 	{0, NULL, 0, NULL, NULL},



More information about the Bf-blender-cvs mailing list