[Bf-blender-cvs] [dbccbc51fb8] master: Fix T63120 Select random in particle edit mode is broken

Sebastian Parborg noreply at git.blender.org
Tue Apr 2 12:39:49 CEST 2019


Commit: dbccbc51fb874b6c0f32c7bf207c208fa98b3f52
Author: Sebastian Parborg
Date:   Tue Apr 2 12:35:16 2019 +0200
Branches: master
https://developer.blender.org/rBdbccbc51fb874b6c0f32c7bf207c208fa98b3f52

Fix T63120 Select random in particle edit mode is broken

Fix coding snafu where the variable keeping track of changes only took
the state of the last element into account.

===================================================================

M	source/blender/editors/physics/particle_edit.c

===================================================================

diff --git a/source/blender/editors/physics/particle_edit.c b/source/blender/editors/physics/particle_edit.c
index bd7f06c9674..112d453c44a 100644
--- a/source/blender/editors/physics/particle_edit.c
+++ b/source/blender/editors/physics/particle_edit.c
@@ -1926,7 +1926,7 @@ static int select_random_exec(bContext *C, wmOperator *op)
 			LOOP_VISIBLE_POINTS {
 				int flag = ((BLI_rng_get_float(rng) < randfac) == select) ? SEL_SELECT : SEL_DESELECT;
 				LOOP_KEYS {
-					data.is_changed = select_action_apply(point, key, flag);
+					data.is_changed |= select_action_apply(point, key, flag);
 				}
 			}
 			break;
@@ -1934,7 +1934,7 @@ static int select_random_exec(bContext *C, wmOperator *op)
 			LOOP_VISIBLE_POINTS {
 				LOOP_VISIBLE_KEYS {
 					int flag = ((BLI_rng_get_float(rng) < randfac) == select) ? SEL_SELECT : SEL_DESELECT;
-					data.is_changed = select_action_apply(point, key, flag);
+					data.is_changed |= select_action_apply(point, key, flag);
 				}
 			}
 			break;



More information about the Bf-blender-cvs mailing list