[Bf-blender-cvs] [6398e6608f5] blender2.8: GPencil: Avoid tautology assignment

Sergey Sharybin noreply at git.blender.org
Fri Sep 28 10:14:22 CEST 2018


Commit: 6398e6608f5d9b8b512d76657325c00a3cd2036c
Author: Sergey Sharybin
Date:   Fri Sep 28 10:10:25 2018 +0200
Branches: blender2.8
https://developer.blender.org/rB6398e6608f5d9b8b512d76657325c00a3cd2036c

GPencil: Avoid tautology assignment

This is considered a warning which is usually promoted to
error in developers' environment.

Probably worth adding an assert or so, if possible?

===================================================================

M	source/blender/gpencil_modifiers/intern/MOD_gpencilhook.c

===================================================================

diff --git a/source/blender/gpencil_modifiers/intern/MOD_gpencilhook.c b/source/blender/gpencil_modifiers/intern/MOD_gpencilhook.c
index 08416f061fe..8f7911834c9 100644
--- a/source/blender/gpencil_modifiers/intern/MOD_gpencilhook.c
+++ b/source/blender/gpencil_modifiers/intern/MOD_gpencilhook.c
@@ -151,7 +151,6 @@ static float gp_hook_falloff(const struct GPHookData_cb *tData,	const float len_
 				fac = sqrtf(2 * fac - fac * fac);
 				break;
 			default:
-				fac = fac;
 				break;
 		}



More information about the Bf-blender-cvs mailing list