[Bf-blender-cvs] [b75648694c5] blender2.8: Cleanup comments on select similar edge

Dalai Felinto noreply at git.blender.org
Wed Sep 26 00:18:56 CEST 2018


Commit: b75648694c5e831c624166c45c0cfb77c64812b7
Author: Dalai Felinto
Date:   Tue Sep 25 17:33:15 2018 -0300
Branches: blender2.8
https://developer.blender.org/rBb75648694c5e831c624166c45c0cfb77c64812b7

Cleanup comments on select similar edge

===================================================================

M	source/blender/editors/mesh/editmesh_select_similar.c

===================================================================

diff --git a/source/blender/editors/mesh/editmesh_select_similar.c b/source/blender/editors/mesh/editmesh_select_similar.c
index 144f5445d08..6d68a7a5c39 100644
--- a/source/blender/editors/mesh/editmesh_select_similar.c
+++ b/source/blender/editors/mesh/editmesh_select_similar.c
@@ -283,13 +283,13 @@ static bool edge_data_value_set(BMEdge *edge, const int hflag, int *r_value)
 	return *r_value != SIMEDGE_DATA_ALL;
 }
 
-/* Note/TODO(dfelinto) technically SIMEDGE_FACE_ANGLE should compare the angles in world space.
- * Although doable this is overkill - at least for the initial multi-objects implementation. */
+/* TODO(dfelinto): `types` that should technically be compared in world space but are not:
+ *  -SIMEDGE_FACE_ANGLE
+ */
 static int similar_edge_select_exec(bContext *C, wmOperator *op)
 {
 	ViewLayer *view_layer = CTX_data_view_layer(C);
 
-	/* get the type from RNA */
 	const int type = RNA_enum_get(op->ptr, "type");
 	const float thresh = RNA_float_get(op->ptr, "threshold");
 	const float thresh_radians = thresh * (float)M_PI + FLT_EPSILON;



More information about the Bf-blender-cvs mailing list