[Bf-blender-cvs] [bd51cada8db] blender2.8: depsgraph: Fix 32 bit shift bug in get_visible_components_mask.

Ray Molenkamp noreply at git.blender.org
Tue Sep 25 17:23:14 CEST 2018


Commit: bd51cada8db64e45cabca66cd61438c1ae2bdf25
Author: Ray Molenkamp
Date:   Tue Sep 25 09:23:00 2018 -0600
Branches: blender2.8
https://developer.blender.org/rBbd51cada8db64e45cabca66cd61438c1ae2bdf25

depsgraph: Fix 32 bit shift bug in get_visible_components_mask.

1 << n results in a 32 bit result, 1UL << n retains all 64 bits.

===================================================================

M	source/blender/depsgraph/intern/nodes/deg_node_id.cc

===================================================================

diff --git a/source/blender/depsgraph/intern/nodes/deg_node_id.cc b/source/blender/depsgraph/intern/nodes/deg_node_id.cc
index caf7c8da3c1..5839cf11e67 100644
--- a/source/blender/depsgraph/intern/nodes/deg_node_id.cc
+++ b/source/blender/depsgraph/intern/nodes/deg_node_id.cc
@@ -230,7 +230,7 @@ IDComponentsMask IDDepsNode::get_visible_components_mask() const {
 		if (comp_node->affects_directly_visible) {
 			const int component_type = comp_node->type;
 			BLI_assert(component_type < 64);
-			result |= (1 << component_type);
+			result |= (1UL << component_type);
 		}
 	}
 	GHASH_FOREACH_END();



More information about the Bf-blender-cvs mailing list