[Bf-blender-cvs] [c6bbe6c5aac] master: Fix (unreported) potentially giant memory leak in Cloth collision solver.

Bastien Montagne noreply at git.blender.org
Mon Sep 3 15:32:44 CEST 2018


Commit: c6bbe6c5aac29a4d36eb3aedd488ca4deac68fb7
Author: Bastien Montagne
Date:   Mon Sep 3 15:30:33 2018 +0200
Branches: master
https://developer.blender.org/rBc6bbe6c5aac29a4d36eb3aedd488ca4deac68fb7

Fix (unreported) potentially giant memory leak in Cloth collision solver.

Not freeing its BVHTree in case there were no collision objects,
could quickly lead to hundreds of MB of memleak!

===================================================================

M	source/blender/blenkernel/intern/collision.c

===================================================================

diff --git a/source/blender/blenkernel/intern/collision.c b/source/blender/blenkernel/intern/collision.c
index b38d6b8bceb..65c84187307 100644
--- a/source/blender/blenkernel/intern/collision.c
+++ b/source/blender/blenkernel/intern/collision.c
@@ -1357,6 +1357,7 @@ void cloth_find_point_contacts(Object *ob, ClothModifierData *clmd, float step,
 	if (!collobjs) {
 		*r_collider_contacts = NULL;
 		*r_totcolliders = 0;
+		BLI_bvhtree_free(cloth_bvh);
 		return;
 	}



More information about the Bf-blender-cvs mailing list