[Bf-blender-cvs] [37ffd95594f] blender2.8: Fix: Drivers popover not showing

Joshua Leung noreply at git.blender.org
Sat Oct 20 04:32:53 CEST 2018


Commit: 37ffd95594fe801cd51f60816e575fb3786cd095
Author: Joshua Leung
Date:   Sat Oct 13 11:32:28 2018 +1300
Branches: blender2.8
https://developer.blender.org/rB37ffd95594fe801cd51f60816e575fb3786cd095

Fix: Drivers popover not showing

This was broken since cca87ccc753a85b447872a259c9d3e3f07ec1c13

The problem was that as this popover was defined in the C-code
for the Graph Editor, the relevant panel never got added to the
WM_paneltype registry, since only Python defined panels get
WM_paneltype_add() called when they are defined.

Since the majority of panels defined for regions are only used there,
a more localised fix was applied here by only adding the driver popover
to the global list manually.

===================================================================

M	source/blender/editors/space_graph/graph_buttons.c

===================================================================

diff --git a/source/blender/editors/space_graph/graph_buttons.c b/source/blender/editors/space_graph/graph_buttons.c
index ddb248f754d..25d1465c579 100644
--- a/source/blender/editors/space_graph/graph_buttons.c
+++ b/source/blender/editors/space_graph/graph_buttons.c
@@ -1197,7 +1197,7 @@ void graph_buttons_register(ARegionType *art)
 	strcpy(pt->translation_context, BLT_I18NCONTEXT_DEFAULT_BPYRNA);
 	pt->draw = graph_panel_drivers_popover;
 	pt->poll = graph_panel_drivers_popover_poll;
-	BLI_addtail(&art->paneltypes, pt);
+	WM_paneltype_add(pt); /* This panel isn't used in this region. Add explicitly to global list (so popovers work). */
 
 	pt = MEM_callocN(sizeof(PanelType), "spacetype graph panel modifiers");
 	strcpy(pt->idname, "GRAPH_PT_modifiers");



More information about the Bf-blender-cvs mailing list