[Bf-blender-cvs] [1dd3b93d2f9] blender2.8: Revert "Cleanup: avoid for loop"

Campbell Barton noreply at git.blender.org
Wed Oct 10 01:57:22 CEST 2018


Commit: 1dd3b93d2f925ad0c3ec6927ce77474b47157ecc
Author: Campbell Barton
Date:   Wed Oct 10 10:54:18 2018 +1100
Branches: blender2.8
https://developer.blender.org/rB1dd3b93d2f925ad0c3ec6927ce77474b47157ecc

Revert "Cleanup: avoid for loop"

This reverts commit 390dc94562ea01e41e560dbee1c481ad6b22eab7.

After testing this is approx half the speed of a for loop.

Add missing break and assign snap_elements to a variable.

===================================================================

M	release/scripts/startup/bl_ui/space_view3d.py

===================================================================

diff --git a/release/scripts/startup/bl_ui/space_view3d.py b/release/scripts/startup/bl_ui/space_view3d.py
index d9f48ffc2b6..22624ce8482 100644
--- a/release/scripts/startup/bl_ui/space_view3d.py
+++ b/release/scripts/startup/bl_ui/space_view3d.py
@@ -154,10 +154,13 @@ class VIEW3D_HT_header(Header):
             snap_elements = tool_settings.snap_elements
             if len(snap_elements) == 1:
                 text = ""
-                icon = snap_items[next(iter(snap_elements))].icon
+                for elem in snap_elements:
+                    icon = snap_items[elem].icon
+                    break
             else:
                 text = "Mix"
                 icon = 'NONE'
+            del snap_items, snap_elements
 
             row = layout.row(align=True)
             row.prop(tool_settings, "use_snap", text="")



More information about the Bf-blender-cvs mailing list