[Bf-blender-cvs] [28d617199dc] blender2.8: ARMATURE_OT_fill: cleanup

Dalai Felinto noreply at git.blender.org
Fri Oct 5 22:50:31 CEST 2018


Commit: 28d617199dcac26f1c96cf62ebbb7bae2086c839
Author: Dalai Felinto
Date:   Fri Oct 5 17:49:26 2018 -0300
Branches: blender2.8
https://developer.blender.org/rB28d617199dcac26f1c96cf62ebbb7bae2086c839

ARMATURE_OT_fill: cleanup

Remove nonsensical insanity check.
Remove FIXME that would never be addressed anyways.

===================================================================

M	source/blender/editors/armature/armature_edit.c

===================================================================

diff --git a/source/blender/editors/armature/armature_edit.c b/source/blender/editors/armature/armature_edit.c
index e32f6030ae3..bc11af7381c 100644
--- a/source/blender/editors/armature/armature_edit.c
+++ b/source/blender/editors/armature/armature_edit.c
@@ -668,11 +668,6 @@ static int armature_fill_bones_exec(bContext *C, wmOperator *op)
 	int count;
 	bool mixed_object_error = false;
 
-	/* sanity checks */
-	if (ELEM(NULL, obedit_active, obedit_active->data)) {
-		return OPERATOR_CANCELLED;
-	}
-
 	/* loop over all bones, and only consider if visible */
 	bArmature *arm = NULL;
 	CTX_DATA_BEGIN_WITH_ID(C, EditBone *, ebone, visible_bones, bArmature *, arm_iter)
@@ -826,7 +821,6 @@ static int armature_fill_bones_exec(bContext *C, wmOperator *op)
 		}
 	}
 	else {
-		/* FIXME.. figure out a method for multiple bones */
 		BKE_reportf(op->reports, RPT_ERROR, "Too many points selected: %d", count);
 		BLI_freelistN(&points);
 		return OPERATOR_CANCELLED;



More information about the Bf-blender-cvs mailing list