[Bf-blender-cvs] [00d438639da] blender2.8: Fix T57929: missing UI updates when changing active object

Philipp Oeser noreply at git.blender.org
Tue Nov 27 11:09:02 CET 2018


Commit: 00d438639dab0370987c330296a3cbc0f4e388de
Author: Philipp Oeser
Date:   Tue Nov 27 10:24:48 2018 +0100
Branches: blender2.8
https://developer.blender.org/rB00d438639dab0370987c330296a3cbc0f4e388de

Fix T57929: missing UI updates when changing active object

was caused by NC_SCENE notifier being skipped with a non-scene reference
showed e.g. in timeline not updating keyframes/cachelines

Maniphest Tasks: T57929

Differential Revision: https://developer.blender.org/D4000

===================================================================

M	source/blender/editors/object/object_select.c

===================================================================

diff --git a/source/blender/editors/object/object_select.c b/source/blender/editors/object/object_select.c
index c4538a8951f..7c03e93f4b2 100644
--- a/source/blender/editors/object/object_select.c
+++ b/source/blender/editors/object/object_select.c
@@ -126,15 +126,11 @@ void ED_object_base_select(Base *base, eObjectSelect_Mode mode)
  */
 void ED_object_base_activate(bContext *C, Base *base)
 {
+	Scene *scene = CTX_data_scene(C);
 	ViewLayer *view_layer = CTX_data_view_layer(C);
 	view_layer->basact = base;
 
-	if (base) {
-		WM_event_add_notifier(C, NC_SCENE | ND_OB_ACTIVE, view_layer);
-	}
-	else {
-		WM_event_add_notifier(C, NC_SCENE | ND_OB_ACTIVE, NULL);
-	}
+	WM_event_add_notifier(C, NC_SCENE | ND_OB_ACTIVE, scene);
 	DEG_id_tag_update(&CTX_data_scene(C)->id, DEG_TAG_SELECT_UPDATE);
 }



More information about the Bf-blender-cvs mailing list