[Bf-blender-cvs] [92166ecd91d] blender2.8: Py API: Remove GPUShader.transform_feedback_enable/disable

Jacques Lucke noreply at git.blender.org
Wed Nov 14 12:27:16 CET 2018


Commit: 92166ecd91dfd464307e5292d1357b6bb652d8d4
Author: Jacques Lucke
Date:   Wed Nov 14 12:26:34 2018 +0100
Branches: blender2.8
https://developer.blender.org/rB92166ecd91dfd464307e5292d1357b6bb652d8d4

Py API: Remove GPUShader.transform_feedback_enable/disable

It couldn't really be used in the current implementation, so it is better to remove it instead of confusing everyone.

===================================================================

M	source/blender/python/gpu/gpu_py_shader.c

===================================================================

diff --git a/source/blender/python/gpu/gpu_py_shader.c b/source/blender/python/gpu/gpu_py_shader.c
index 46acf22d7e2..eeacd087884 100644
--- a/source/blender/python/gpu/gpu_py_shader.c
+++ b/source/blender/python/gpu/gpu_py_shader.c
@@ -153,35 +153,6 @@ static PyObject *bpygpu_shader_bind(BPyGPUShader *self)
 	Py_RETURN_NONE;
 }
 
-PyDoc_STRVAR(bpygpu_shader_transform_feedback_enable_doc,
-".. method:: transform_feedback_enable(vbo_id)\n"
-"\n"
-"   Start transform feedback operation.\n"
-"\n"
-"   :return: true if transform feedback was succesfully enabled.\n"
-"   :rtype: `bool`\n"
-);
-static PyObject *bpygpu_shader_transform_feedback_enable(
-        BPyGPUShader *self, PyObject *arg)
-{
-	uint vbo_id;
-	if ((vbo_id = PyC_Long_AsU32(arg)) == (uint)-1) {
-		return NULL;
-	}
-	return PyBool_FromLong(GPU_shader_transform_feedback_enable(self->shader, vbo_id));
-}
-
-PyDoc_STRVAR(bpygpu_shader_transform_feedback_disable_doc,
-".. method:: transform_feedback_disable()\n"
-"\n"
-"   Disable transform feedback.\n"
-);
-static PyObject *bpygpu_transform_feedback_disable(BPyGPUShader *self)
-{
-	GPU_shader_transform_feedback_disable(self->shader);
-	Py_RETURN_NONE;
-}
-
 PyDoc_STRVAR(bpygpu_shader_uniform_from_name_doc,
 ".. method:: uniform_from_name(name)\n"
 "\n"
@@ -610,12 +581,6 @@ static PyObject *bpygpu_shader_calc_format(BPyGPUShader *self, PyObject *UNUSED(
 static struct PyMethodDef bpygpu_shader_methods[] = {
 	{"bind", (PyCFunction)bpygpu_shader_bind,
 	 METH_NOARGS, bpygpu_shader_bind_doc},
-	{"transform_feedback_enable",
-	 (PyCFunction)bpygpu_shader_transform_feedback_enable,
-	 METH_O, bpygpu_shader_transform_feedback_enable_doc},
-	{"transform_feedback_disable",
-	 (PyCFunction)bpygpu_transform_feedback_disable,
-	 METH_NOARGS, bpygpu_shader_transform_feedback_disable_doc},
 	{"uniform_from_name",
 	 (PyCFunction)bpygpu_shader_uniform_from_name,
 	 METH_O, bpygpu_shader_uniform_from_name_doc},



More information about the Bf-blender-cvs mailing list