[Bf-blender-cvs] [42d6b8efc0c] blender2.8: RNA: re-enable property notifiers
Campbell Barton
noreply at git.blender.org
Mon May 28 18:18:18 CEST 2018
Commit: 42d6b8efc0cb0c5385f6b6fc6e8ba96d4dc9a93d
Author: Campbell Barton
Date: Mon May 28 17:01:32 2018 +0200
Branches: blender2.8
https://developer.blender.org/rB42d6b8efc0cb0c5385f6b6fc6e8ba96d4dc9a93d
RNA: re-enable property notifiers
While these will be removed eventually,
it makes tracking down COW buts a hassle.
===================================================================
M source/blender/makesrna/intern/rna_access.c
===================================================================
diff --git a/source/blender/makesrna/intern/rna_access.c b/source/blender/makesrna/intern/rna_access.c
index 4c27d3d2226..5a0dec28324 100644
--- a/source/blender/makesrna/intern/rna_access.c
+++ b/source/blender/makesrna/intern/rna_access.c
@@ -2064,10 +2064,15 @@ static void rna_property_update(bContext *C, Main *bmain, Scene *scene, PointerR
else
prop->update(bmain, scene, ptr);
}
-#if 0
- if (prop->noteflag)
+
+#if 1
+ /* TODO(campbell): Should eventually be replaced entirely by message bus (below)
+ * for now keep since COW, bugs are hard to track when we have other missing updates. */
+ if (prop->noteflag) {
WM_main_add_notifier(prop->noteflag, ptr->id.data);
-#else
+ }
+#endif
+
/* if C is NULL, we're updating from animation.
* avoid slow-down from f-curves by not publishing (for now). */
if (C != NULL) {
@@ -2081,9 +2086,9 @@ static void rna_property_update(bContext *C, Main *bmain, Scene *scene, PointerR
DEG_id_tag_update(ptr->id.data, DEG_TAG_COPY_ON_WRITE);
}
}
-#endif
+ /* End message bus. */
}
-
+
if (!is_rna || (prop->flag & PROP_IDPROPERTY)) {
/* WARNING! This is so property drivers update the display!
* not especially nice */
More information about the Bf-blender-cvs
mailing list